Bug 1647094 - CVE-2016-10730 amanda: amstar Command Injection Privilege Escalation [fedora-all]
Summary: CVE-2016-10730 amanda: amstar Command Injection Privilege Escalation [fedora-...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: amanda
Version: 29
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Josef Ridky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: CVE-2016-10730
TreeView+ depends on / blocked
 
Reported: 2018-11-06 16:31 UTC by Laura Pardo
Modified: 2018-11-07 14:32 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-11-06 17:06:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Laura Pardo 2018-11-06 16:31:09 UTC
This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Comment 1 Laura Pardo 2018-11-06 16:31:15 UTC
Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1647090,1647094

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Jason Tibbitts 2018-11-06 17:06:45 UTC
Amanda 3.5.1 (current in all live Fedora releases) is does not allow the specification of arbitrary paths for the --star-path option to amstar:

security file '/etc/amanda-security.conf' do not allow to run '/tmp/foo' as root for 'amstar:star_path'

Allowed paths must be explicitly configured in /etc/amanda-security.conf (which is only writable by root), and by default no paths besides /usr/bin/star are included.

amstar itself is only executable by group disk:

ἐπιθυμία:~❯ ls -l /usr/lib64/amanda/application/amstar
-rwsr-x---. 1 root disk 45848 Aug 20 07:36 /usr/lib64/amanda/application/amstar*

Comment 3 Jason Tibbitts 2018-11-06 17:12:14 UTC
Also note the following:

                Release Notes for amanda-3.3.9

* security-fix
    - All previous release of amanda allow the 'amanda' user to execute
      any code as root, and to execute an interactive shell as root.
    - This is a security vulnerability if you do not trust the 'amanda'
      user.
    - There is no need to upgrade if you trust the 'amanda' user and the
      account is secure.
        - good password
        - secure xinetd.conf setting
        - securae .amandahosts setting
    - The 'amanda' user can read all files in the machine, it is what a
      backup program do.
    - The set of fix disable the abilities to run unwanted code as root
      or to write file anywhere in the filesystem.


Note You need to log in before you can comment on or make changes to this bug.