The server doesn't seem to answer, could you put the files on your Fedorapeople space?

Thank you.
Spec URL changed to : https://people.redhat.com/pmoravec/wfdb/wfdb.spec
SRPM URL changed to: https://people.redhat.com/pmoravec/wfdb/wfdb-10.6.0-1.fc27.src.rpm

 - Vendor: is forbidden in Fedora

 - Not needed anymore:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

 Use %ldconfig_scriptlets for F27 or EPEL. See https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

 - Not needed, it is the default:

%defattr(-,root,root,-)

 - You forgot %{?_isa} in the Requires for the devel subpackage:

Requires: %{name}%{?_isa} = %{version}-%{release}

 - This part should be in %build:

cd doc/wpg-src
%__make 
cd ../wag-src
# package pdftk  was removed from distribution (in F21) replace it by qpdf command
sed -i -e 's/pdftk/qpdf --empty wag.pdf --pages wag1.pdf wag2.pdf wag3.pdf wag4.pdf --  # /g' Makefile
%__make
cd ../wug-src
%__make

 - Use make, not %__make. These kind of macros are not useful.

 - You could use pushd/popd instead of cd ../ in that section

 - GCC should be a BR rot a RR

BuildRequires:       gcc

 - Remove the glob here to own the include dir:

%files devel
%{_includedir}/%{name}/
%{_libdir}/libwfdb.so

 - Same here and own %{_datadir}/%{name}

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/database/
%{_datadir}/%{name}/ps/

 - Your build must respect Fedora's CCFLAGS and LDFLAGS

 - Build fails:

DEBUG util.py:490:  BUILDSTDERR: No matching package to install: 'rman'
DEBUG util.py:490:  BUILDSTDERR: Not all dependencies satisfied
DEBUG util.py:490:  BUILDSTDERR: Error: Some packages could not be found.

I have no idea what rman is in this context.

Also, it seems some tests only work with network access, which won't work in Mock/Koji.

Regarding rman:

https://src.fedoraproject.org/rpms/rman/blob/master/f/dead.package

	
Package was removed due to licensing issues (it was only available under Artistic 1.0).
	
Every effort was made to contact upstream for relicensing, but no response was ever received.
 
	
See: https://fedoraproject.org/wiki/Features/Artistic1Removal


No luck there.

Thank you. Errors corrected and wfdb-doc package removed.

Spec URL: https://people.redhat.com/pmoravec/wfdb/wfdb.spec
SRPM URL: https://people.redhat.com/pmoravec/wfdb/wfdb-10.6.0-1.fc27.src.rpm

Tests fail in mock because they need an internet access, try to disable the tests.

Provided links do not work anymore. But found them in subdirectory:

Spec URL: https://people.redhat.com/pmoravec/wfdb/10.6.0-2/wfdb.spec
SRPM URL: https://people.redhat.com/pmoravec/wfdb/10.6.0-2/wfdb-10.6.0-2.fc27.src.rpm

Are you still insterested in review?

Still does not build to me.
make[2]: Leaving directory '/builddir/build/BUILD/wfdb-10.6.0/checkpkg'
chyby sestavení RPM:
BUILDSTDERR: make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
BUILDSTDERR: lcheck.c:42:1: warning: return type defaults to 'int' [-Wimplicit-int]
BUILDSTDERR:  main(argc, argv)
BUILDSTDERR:  ^~~~
BUILDSTDERR: lcheck.c: In function 'main':
BUILDSTDERR: lcheck.c:177:3: warning: implicit declaration of function 'check' [-Wimplicit-function-declaration]
BUILDSTDERR:    check("100s", "100z");
BUILDSTDERR:    ^~~~~
BUILDSTDERR: Testing WFDB library version 10.6.0 (Apr  4 2019).
BUILDSTDERR: init: can't open header for record udb/100s
BUILDSTDERR: annopen: can't read annotator atr for record udb/100s
BUILDSTDERR: Error: annopen of 1 file returned -3 (should have been 0)
BUILDSTDERR: annopen: can't read annotator atr for record udb/100s
BUILDSTDERR: Error: annopen of 2 files returned -3 (should have been 0)
BUILDSTDERR: getann: can't read annotator 0
BUILDSTDERR: getann: can't read annotator 0
BUILDSTDERR: getann: can't read annotator 0
BUILDSTDERR: getann: can't read annotator 0
BUILDSTDERR: getann: can't read annotator 0
BUILDSTDERR: getann: can't read annotator 0
BUILDSTDERR: init: can't open header for record udb/100s
BUILDSTDERR: Error: isigopen(udb/100s, NULL, 0) returned -1 (should have been 2)
BUILDSTDERR: init: can't open header for record udb/100s
BUILDSTDERR: rmdir: failed to remove 'udb': Directory not empty
BUILDSTDERR: make[2]: [Makefile:252: all] Error 1 (ignored)
BUILDSTDERR: make[2]: *** [Makefile:256: all] Error 1
BUILDSTDERR: make[1]: *** [Makefile:348: check] Error 2
BUILDSTDERR: make: *** [Makefile:265: all] Error 2
BUILDSTDERR: chyba: Špatný návratový kód z /var/tmp/rpm-tmp.a4Uyye (%build)
BUILDSTDERR:     Špatný návratový kód z /var/tmp/rpm-tmp.a4Uyye (%build)
Child return code was: 1
EXCEPTION: [Error()]


It seems just %make_build WFDB_NO_NET_CHECK=yes has to be used in spec file to pass it.

> It seems just %make_build WFDB_NO_NET_CHECK=yes has to be used in spec file
> to pass it.

Thanks for the suggestion, it really works.

I added it to the current version of the package:

https://people.redhat.com/pmoravec/wfdb/10.6.0-3/

I think there is problem with both library and binaries are installed in the same package. I think %package libs should be created for library alone and main package should Requires: %{name}-libs%{?_isa} = %{version}-%{release}
The same requires should be in devel subpackage. %license should be moved to libs also, because that would be required by all other packages.

It is a bit surprising all tools are installed into %{_sbindir} instead of %{_bindir}

Hi. According to [1] application and library must be in separate package. Please separate it to finish the review.

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_libraries_and_applications

For the lack of reaction, I am leaving this review for anyone else.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.