Bug 1647455 - [RFE][REST] Provide information about the VM next run
Summary: [RFE][REST] Provide information about the VM next run
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.2.6
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Nobody
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks: 1647473
TreeView+ depends on / blocked
 
Reported: 2018-11-07 14:01 UTC by Roman Hodain
Modified: 2023-09-15 00:13 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of: 1647440
: 1647473 (view as bug list)
Environment:
Last Closed: 2018-11-14 10:22:33 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:
lsvaty: testing_plan_complete-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-45212 0 None None None 2022-03-13 16:16:58 UTC

Comment 1 Ryan Barry 2018-11-08 05:38:46 UTC
Do we really need a flag here?

The API is intended for an advanced, concrete use case where users/customers need to automate a specific series of steps. There should not be ambiguity about what has happened.

It would be better for ansible to default to next_run true.

The principal problem with this request is that it requiree manual intervention, review, and/or script modifications to even catch this output, instead of a more sane default

Comment 2 Michal Skrivanek 2018-11-08 05:48:44 UTC
There is a clear way how to request that, there’s the next_run parameter, and.there is the configuration in NEXT_RUN snapshot which can be retrieved. It’s not very convenient or straightforward for end user, but indeed API is for advanced usage and automation

Comment 5 Ondra Machacek 2018-11-08 14:07:16 UTC
We already have this functionality.

If you retrieve /api/vms/123 and you find the parameter next_run_configuration_exists set to true, you can then fetch the next_run configuration as:

/api/vms/123?next_run=true, and compare the previous output with this one to see what will be changed.

Is this sufficient?

Comment 6 Ryan Barry 2018-11-13 03:23:30 UTC
This is already available. Please re-open if the information in comment#5 is not sufficient

Comment 7 Roman Hodain 2018-11-13 08:53:26 UTC
(In reply to Ondra Machacek from comment #5)
> We already have this functionality.
> 
> If you retrieve /api/vms/123 and you find the parameter
> next_run_configuration_exists set to true, you can then fetch the next_run
> configuration as:
> 
> /api/vms/123?next_run=true, and compare the previous output with this one to
> see what will be changed.
> 
> Is this sufficient?

Hi,

so how are we expect the users to use this feature? I understand that in case we use directly RestAPI or SDK. We are expected to process the results. But what about the stacket management tools like Ansible. There is no proper way to process the output in Ansible. The comparison of the current configuration and the next run is close to impossible. 

If you want to see the next run you are mostly interested only in the changes. I believe that the API/Ansible should make it much easier than now.

What do you think?

Comment 9 Martin Tessun 2018-11-14 10:18:26 UTC
(In reply to Roman Hodain from comment #7)
> (In reply to Ondra Machacek from comment #5)
> > We already have this functionality.
> > 
> > If you retrieve /api/vms/123 and you find the parameter
> > next_run_configuration_exists set to true, you can then fetch the next_run
> > configuration as:
> > 
> > /api/vms/123?next_run=true, and compare the previous output with this one to
> > see what will be changed.
> > 
> > Is this sufficient?
> 
> Hi,
> 
> so how are we expect the users to use this feature? I understand that in
> case we use directly RestAPI or SDK. We are expected to process the results.
> But what about the stacket management tools like Ansible. There is no proper
> way to process the output in Ansible. The comparison of the current
> configuration and the next run is close to impossible. 

So we should open a BZ for Ansible, as it makes sense to have that in the "higher management" functions. As the API provides this functionality, in case the customes is using the API, he is also in charge of checking this, if needed.

I would propose a warning from ansible in case there is a next-run config available, so the consumer knows he should check that one as well.

I don't think we should "automagically" update the next_run as well, as it could be wanted.
As such I think  a warning in Ansible is sufficient.

> 
> If you want to see the next run you are mostly interested only in the
> changes. I believe that the API/Ansible should make it much easier than now.
> 

I believe it makes sense to have that in Ansible.
@Moran: Could you move that BZ to Ansible after reviewing the ask?

> What do you think?

Comment 13 Red Hat Bugzilla 2023-09-15 00:13:46 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days


Note You need to log in before you can comment on or make changes to this bug.