RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1647789 - Run restorecon and semanage in %posttrans
Summary: Run restorecon and semanage in %posttrans
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: spice-streaming-agent
Version: 7.6
Hardware: All
OS: Linux
urgent
high
Target Milestone: rc
: ---
Assignee: Uri Lublin
QA Contact: SPICE QE bug list
URL:
Whiteboard:
Depends On:
Blocks: 1568427 1670353
TreeView+ depends on / blocked
 
Reported: 2018-11-08 11:19 UTC by Jan Stodola
Modified: 2019-08-06 13:17 UTC (History)
3 users (show)

Fixed In Version: spice-streaming-agent-0.2-4.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 13:17:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
v1-call-semanage-in-posttrans-not-in-post (2.71 KB, patch)
2019-04-10 16:10 UTC, Uri Lublin
no flags Details | Diff
v2-call-semanage-in-posttrans-no-in-post (2.01 KB, patch)
2019-04-10 16:17 UTC, Uri Lublin
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:2309 0 None None None 2019-08-06 13:17:33 UTC

Description Jan Stodola 2018-11-08 11:19:04 UTC
Description of problem:
%post scriptlet of spice-streaming-agent executes restorecon and semanage:

[root@localhost ~]# rpm -q --scripts spice-streaming-agent
postinstall scriptlet (using /bin/sh):
semanage fcontext -a -t xserver_exec_t /usr/bin/spice-streaming-agent 2>/dev/null || :
restorecon /usr/bin/spice-streaming-agent || :
...

But restorecon and semanage don't work if selinux-policy-* is not yet installed (for example during the installation of a system, see bug 1367433 for details). It was recommended to execute the commands in %posttrans to avoid possible issues with the SELinux policy being installed later in the transaction.
Bug 1367433 comment 14: "You should also hide the stderr output of restorecon for when the package is installed on a system with disabled selinux (or inside a container). In such case the command is expected to fail (and the message is therefore harmless)."

Version-Release number of selected component (if applicable):
RHEL-7.6
spice-streaming-agent-0.2-3.el7

How reproducible:
always

Steps to Reproduce:
1. check rpm scriptlets

Actual results:
restorecon and semanage are executed in %post

Expected results:
restorecon and semanage are executed in %posttrans, stderr is redirected to /dev/null

Comment 3 Uri Lublin 2019-04-10 16:10:47 UTC
Created attachment 1554301 [details]
v1-call-semanage-in-posttrans-not-in-post

replace %post with %posttrans and also add some checks to scriptlets

Comment 4 Uri Lublin 2019-04-10 16:17:07 UTC
Created attachment 1554303 [details]
v2-call-semanage-in-posttrans-no-in-post

Replace %post with %posttrans

A simpler patch, without modifying the scriptlets.

Sent upstream as
 https://lists.freedesktop.org/archives/spice-devel/2019-January/047666.html

Comment 6 Jakub Vavra 2019-04-16 11:52:29 UTC
I still see the issue in nightlies (RHEL-7.7-20190415.n.1), maybe there is some action needed to have the fix in compose?
10:44:19,990 INFO packaging: spice-streaming-agent-0.2-3.el7.x86_64 (1287/1442)
10:44:19,990 INFO packaging: No such file or directory

Comment 7 Jakub Vavra 2019-04-17 06:45:57 UTC
Ok, the issue is gone. I no longer see it there during the installation (RHEL-7.7-20190416.n.0):
...
16:39:15,942 INFO packaging: spice-streaming-agent-0.2-4.el7.x86_64 (1302/1442)
16:39:15,943 INFO packaging: pm-utils-1.4.1-27.el7.x86_64 (1303/1442)
...

Comment 9 errata-xmlrpc 2019-08-06 13:17:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2309


Note You need to log in before you can comment on or make changes to this bug.