Bug 164837 - Use GET for buildsys web forms
Summary: Use GET for buildsys web forms
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora Infrastructure
Classification: Retired
Component: extras buildsys
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Seth Vidal
QA Contact: Jeremy Katz
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-08-01 18:30 UTC by Ville Skyttä
Modified: 2007-04-18 17:30 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-11 19:33:59 UTC
Embargoed:


Attachments (Terms of Use)
Use GET for web UI forms (1.69 KB, patch)
2005-08-01 18:30 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2005-08-01 18:30:40 UTC
Attached is a patch for the buildsys web interface, changing use of POST to  
GET for all forms: there's not that much data sent that would need POST, and  
using GET makes the UI more back/forward/reload friendly in browsers.  
Untested, but "trivial, should work (tm)".

Comment 1 Ville Skyttä 2005-08-01 18:30:47 UTC
Created attachment 117351 [details]
Use GET for web UI forms

Comment 2 Seth Vidal 2005-08-01 18:41:59 UTC
try appending email= to the strings in the current web interface.

I think you'll find they just work.



Comment 4 Ville Skyttä 2005-08-02 07:51:17 UTC
Sure, but why on earth should I have to type something to the URL while there's
a web interface for human consumption for it?

A counterexample:

Enter "117" to the "Job ID" text box, and click "Go".  Now, hit the browser's
reload button and be annoyed by the browser's confirmation dialog about
resending the form POST data.  If GET was used instead of POST, this would Just
Work(tm).

Comment 5 Dan Williams 2005-08-11 19:33:59 UTC
committed to CVS, will be in 0.3.1


Note You need to log in before you can comment on or make changes to this bug.