Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-osd2web.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-graphlcd-1.0.0-1.fc29.src.rpm Description: graphlcd is a plugin for the Video Disc Recorder and shows information about the current state of VDR on displays supported by the GraphLCD driver library. Fedora Account System Username: martinkg rpmlint -i -v vdr-graphlcd.spec /home/martin/rpmbuild/SRPMS/vdr-graphlcd-1.0.0-1.fc29.src.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-graphlcd-1.0.0-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-graphlcd-debugsource-1.0.0-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-graphlcd-debuginfo-1.0.0-1.fc29.x86_64.rpm vdr-graphlcd.spec: I: checking vdr-graphlcd.spec:54: W: macro-in-comment %config There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.spec:54: W: macro-in-comment %{vdr_plugin_cfgdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.spec: I: checking-url https://projects.vdr-developer.org/git/vdr-plugin-graphlcd.git/snapshot/vdr-plugin-graphlcd-1.0.0.tar.bz2 (timeout 10 seconds) vdr-graphlcd.src: I: checking vdr-graphlcd.src: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd.src: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. vdr-graphlcd.src:54: W: macro-in-comment %config There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.src:54: W: macro-in-comment %{vdr_plugin_cfgdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.src: I: checking-url https://projects.vdr-developer.org/git/vdr-plugin-graphlcd.git/snapshot/vdr-plugin-graphlcd-1.0.0.tar.bz2 (timeout 10 seconds) vdr-graphlcd.x86_64: I: checking vdr-graphlcd.x86_64: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd.x86_64: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. vdr-graphlcd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/vdr/plugins/graphlcd/channels.alias A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var. vdr-graphlcd.x86_64: W: file-not-utf8 /usr/share/doc/vdr-graphlcd/HISTORY The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). vdr-graphlcd.x86_64: E: incorrect-fsf-address /usr/share/licenses/vdr-graphlcd/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/DejaVuSans-Bold.ttf /usr/share/fonts/dejavu/DejaVuSans-Bold.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/DejaVuSansCondensed.ttf /usr/share/fonts/dejavu/DejaVuSansCondensed.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/VeraBd.ttf /usr/share/fonts/bitstream-vera/VeraBd.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd-debugsource.x86_64: I: checking vdr-graphlcd-debugsource.x86_64: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd-debugsource.x86_64: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. vdr-graphlcd-debuginfo.x86_64: I: checking vdr-graphlcd-debuginfo.x86_64: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd-debuginfo.x86_64: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. 4 packages and 1 specfiles checked; 1 errors, 14 warnings.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-osd2web.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-graphlcd-1.0.0-2.fc29.src.rpm %changelog * Sat Nov 10 2018 Martin Gansser <martinkg> - 1.0.0-2 - Add %%{name}-Improved-trim-function.patch
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-graphlcd.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-graphlcd-1.0.1-1.fc29.src.rpm %changelog * Sat Nov 10 2018 Martin Gansser <martinkg> - 1.0.1-1 - Update to 1.0.1
- You're missing some BR: BUILDSTDERR: Package freetype2 was not found in the pkg-config search path. BUILDSTDERR: Perhaps you should add the directory containing `freetype2.pc' BUILDSTDERR: to the PKG_CONFIG_PATH environment variable BUILDSTDERR: Package 'freetype2', required by 'virtual:world', not found BUILDSTDERR: /bin/sh: g++: command not found Add: BuildRequires: gcc-c++ BuildRequires: pkgconfig(freetype2) - License is GPLv2+ not GPL+ - Convert this file to utf-8: vdr-graphlcd.x86_64: W: file-not-utf8 /usr/share/doc/vdr-graphlcd/HISTORY Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License", "GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 1074 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/vdr-graphlcd/review-vdr- graphlcd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vdr- graphlcd-debuginfo , vdr-graphlcd-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1812480 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vdr-graphlcd-1.0.1-1.fc30.x86_64.rpm vdr-graphlcd-debuginfo-1.0.1-1.fc30.x86_64.rpm vdr-graphlcd-debugsource-1.0.1-1.fc30.x86_64.rpm vdr-graphlcd-1.0.1-1.fc30.src.rpm vdr-graphlcd.x86_64: W: invalid-url URL: http://projects.vdr-developer.org/projects/show/graphlcd/ HTTP Error 404: Not Found vdr-graphlcd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/vdr/plugins/graphlcd/channels.alias vdr-graphlcd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/vdr/plugins/graphlcd/fonts.conf vdr-graphlcd.x86_64: W: file-not-utf8 /usr/share/doc/vdr-graphlcd/HISTORY vdr-graphlcd.x86_64: E: incorrect-fsf-address /usr/share/licenses/vdr-graphlcd/COPYING vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/DejaVuSans-Bold.ttf /usr/share/fonts/dejavu/DejaVuSans-Bold.ttf vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/DejaVuSansCondensed.ttf /usr/share/fonts/dejavu/DejaVuSansCondensed.ttf vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/VeraBd.ttf /usr/share/fonts/bitstream-vera/VeraBd.ttf vdr-graphlcd-debuginfo.x86_64: W: invalid-url URL: http://projects.vdr-developer.org/projects/show/graphlcd/ HTTP Error 404: Not Found vdr-graphlcd-debugsource.x86_64: W: invalid-url URL: http://projects.vdr-developer.org/projects/show/graphlcd/ HTTP Error 404: Not Found vdr-graphlcd.src: W: invalid-url URL: http://projects.vdr-developer.org/projects/show/graphlcd/ HTTP Error 404: Not Found vdr-graphlcd.src: E: specfile-error warning: line 18: Possible unexpanded macro in: Requires: vdr(abi)(x86-64) = %{vdr_apiversion} 4 packages and 0 specfiles checked; 2 errors, 11 warnings.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-graphlcd.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-graphlcd-1.0.1-2.fc29.src.rpm %changelog * Sat Nov 19 2018 Martin Gansser <martinkg> - 1.0.1-2 - Add BR gcc-c++ - Add BR pkgconfig(freetype2) - License is GPLv2+ not GPL+ - Convert HISTORY file to utf-8
Package approved.
Many Thanks for the review.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vdr-graphlcd