Bug 1648832

Description of problem:

prerequisites.yml is failed with the following error messages on OpenStack provider. Because the hostname sets up  as "xxx.xxx.xxx.xxx,yyy.yyy.yyy.yyy" format.


~~~
TASK [Query DNS for IP address of 10.0.1.1,10.0.2.2] ****************************************
> ok: [master1.example.com] => {"changed": false, "cmd": "getent ahostsv4 10.0.1.1,10.0.2.2 | head -n 1 | awk '{ print $1 }'", "delta": "0:00:04.234768", "end": "2018-11-07 06:28:45.514534", "failed": false, "failed_when_result": false, "rc": 0, "start": "2018-11-07 06:28:41.279799", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
~~~

Version-Release number of selected component (if applicable):

I could verify this issue on v3.9 but it can be problematic in v3.10 and v3.11 either.

openshift v3.9.43
kubernetes v1.9.1+a0ce1bc657

rpm -q openshift-ansible
openshift-ansible-3.9.41-1.git.0.4c55974.el7.noarch

rpm -q ansible
ansible-2.4.6.0-1.el7ae.noarch

ansible --version
ansible 2.4.6.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May 31 2018, 09:41:32) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]


How reproducible:

If you install OCP on OpenStack, then you can use metadata service using 'curl' and the output is as follows.

# curl http://169.254.169.254/latest/meta-data/local-ipv4
10.0.1.1,10.0.2.2

And then you can reproduce by running prerequisites.yml


Steps to Reproduce:
1.
2.
3.

Actual results:

wrong value would set up as hostname, so it was failed during prerequisites.yml.

Expected results:

the DNS query would resolve as correct hostname.

Additional info:

Root cause is here in openshift_facts.py.

https://github.com/openshift/openshift-ansible/blob/release-3.11/roles/openshift_facts/library/openshift_facts.py#L307-L315

~~~
    for f_var, h_var, ip_var in [('hostname', 'hostname', 'local-ipv4'),
                                 ('public_hostname', 'public-hostname', 'public-ipv4')]:
        try:
            if socket.gethostbyname(metadata['ec2_compat'][h_var]) == metadata['ec2_compat'][ip_var]:
                facts['network'][f_var] = metadata['ec2_compat'][h_var]
            else:
                facts['network'][f_var] = metadata['ec2_compat'][ip_var]
        except socket.gaierror:
            facts['network'][f_var] = metadata['ec2_compat'][ip_var]
~~~

The partial result of openshift_facts role:
~~~
               "provider": {
                    "metadata": {                        
                        "ec2_compat": {
                            ...
                            },
                            "hostname": "master1.example.com",
                            ...                            
                            "local-hostname": "master1.example.com",
                            "local-ipv4": "10.0.1.1,10.0.2.2",
                            ...
                            "public-hostname": "master1.example.com",
                            "public-ipv4": [],
                   ...
                   "name": "openstack",
                    "network": {
                        "hostname": "10.0.1.1,10.0.2.2",
                        "ip": "10.0.1.1",
                        "public_hostname": [],
                        "public_ip": []
                    },
~~~