Bug 1649280 - Mandatory fields during creation of cloud network are not marked as mandatory
Summary: Mandatory fields during creation of cloud network are not marked as mandatory
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: GA
: 5.11.0
Assignee: Richard Vsiansky
QA Contact: Matouš Mojžíš
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-13 10:16 UTC by Jan Zmeskal
Modified: 2020-01-09 15:46 UTC (History)
10 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:34:23 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Screenshot 1 (37.92 KB, image/png)
2018-11-13 10:16 UTC, Jan Zmeskal
no flags Details
Screenshot 2 (20.51 KB, image/png)
2018-11-13 10:16 UTC, Jan Zmeskal
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:34:38 UTC

Description Jan Zmeskal 2018-11-13 10:16:17 UTC
Created attachment 1505183 [details]
Screenshot 1

Description of problem:
When you try to create various types of cloud networks in CFME UI, some fields (namely Physical Network and Segmentation ID) are actually mandatory, but are not marked as such in the UI. You only find out they are mandatory once you attempt to add the network and you're met with error flash message.


Version-Release number of selected component (if applicable):
5.10.0.23

How reproducible:
100 %

Steps to Reproduce:
1. Have a CFME appliance with some network provider
2. Go to Networks -> Networks.
3. Click Configuration -> Add a new Cloud Network.
4. Select a Network Manager and a Cloud Tenant. Now as a Provider Network Type, select something that gives you the opportunity to provide additional information  e.g. VLAN. 
5. Fill ONLY the fields that are marked as required. In this case, it should be only Network Name (screenshot 1).
6. Click the Add button.

Actual results:
You are met with error flash message saying: 
Unable to create Cloud Network "<your_network_name>": { "error": { "message": "provider:segmentation_id is mandatory for network type vlan", "code": 400, "title": "Bad Request" } }. See screenshot 2.

Expected results:
I think all the required field should be marked as such in the UI.

Comment 2 Jan Zmeskal 2018-11-13 10:16:35 UTC
Created attachment 1505184 [details]
Screenshot 2

Comment 7 CFME Bot 2019-03-26 09:49:48 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/02eb283fa14f0faf784f130a7d6ee0d1e173db88
commit 02eb283fa14f0faf784f130a7d6ee0d1e173db88
Author:     Richard Vsiansky <r.vsia>
AuthorDate: Thu Mar 21 10:09:42 2019 -0400
Commit:     Richard Vsiansky <r.vsia>
CommitDate: Thu Mar 21 10:09:42 2019 -0400

    Fixes segmentation_id and physical network required

    fixes  https://bugzilla.redhat.com/show_bug.cgi?id=1649280

    FLAT -> segmentation_id not needed
    GRE -> segmentation_id is GRE ID
    VLAN -> segmentation_id is VLAN ID
    VXLAN -> segmentation_id not needed

    Physical network:
    It isn't required for VXLAN and GRE
    But VLAN and Flat do require it. In which case the value is provided by a logical name (mapping to a real physical network)

 app/assets/javascripts/components/cloud_network/cloud-network-form.js | 2 +
 app/views/static/cloud_network/cloud-network-form.html.haml | 12 +-
 2 files changed, 12 insertions(+), 2 deletions(-)

Comment 8 juwatts 2019-07-02 18:03:11 UTC
Verified in 5.11.0.11.20190625161125_392c61e


Verifications Steps"
1) Added a RHEV Provider to CFME
2) Navigate to Networks->Networks
3) Select the Configuration drop down menu and select "Add a new Cloud Network"
4) Select the rhv network manager for the Network Manager and the appropriate tenant

Physical Network, Segmentation ID, Network Name are all required fields. The Add button is also disabled if these fields are not filled in.

Comment 10 errata-xmlrpc 2019-12-12 13:34:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.