Bug 1649655 - [cockpit] Editing the generated gdeploy configuration file doesn't have effect on deployment
Summary: [cockpit] Editing the generated gdeploy configuration file doesn't have effec...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.11.29
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.8
: ---
Assignee: Gobinda Das
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1649653 cockpit-ovirt-0.11.38
TreeView+ depends on / blocked
 
Reported: 2018-11-14 07:17 UTC by SATHEESARAN
Modified: 2019-01-22 10:23 UTC (History)
7 users (show)

Fixed In Version: cockpit-ovirt-0.11.38-1
Clone Of: 1649653
Environment:
Last Closed: 2019-01-22 10:23:36 UTC
oVirt Team: Gluster
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 95423 0 master ABANDONED Removing edit option on the Gluster Deployment Review Step The UI changes can be seen here - https://imgur.com/a/wsR5eAr 2018-12-27 08:52:09 UTC
oVirt gerrit 96584 0 master MERGED Save edited gdeploy conf file and take backup of previous one 2019-01-03 09:23:52 UTC
oVirt gerrit 96586 0 ovirt-4.2 MERGED Save edited gdeploy conf file and take backup of previous one 2019-01-03 09:49:17 UTC

Description SATHEESARAN 2018-11-14 07:17:01 UTC
Description of problem:
-----------------------
While deploying RHHI-V using cockpit, the gdeploy configuration file is generated as per the user input values for hosts, volumes, and bricks.

But when this generated configuration file is edited, saved, then continued with deployment, the deployment still uses the old generated gdeploy config file only, new edits are not honoured

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHHI-V 1.5 ( RHV 4.2.7-1 async & RHGS 3.4.1 )
cockpit-ovirt-dashboard-0.11.37-1

How reproducible:
------------------
Always

Steps to Reproduce:
-------------------
1. Start RHHI-V deployment from cockpit UI with required values
2. Edit the generated gdeploy configuration file from the cockpit last tab and save it
3. Continue with the deployment
4. Check for deployment happens as per the new edit

Actual results:
---------------
Deployment happens as per the generated gdeploy configuration and new edits are dropped

Expected results:
-----------------
The new edits ( modifications ) should over-ride the generated gdpeploy configuration

Comment 1 Parth Dhanjal 2018-11-14 09:00:12 UTC
(In reply to SATHEESARAN from comment #0)
> Description of problem:
> -----------------------
> While deploying RHHI-V using cockpit, the gdeploy configuration file is
> generated as per the user input values for hosts, volumes, and bricks.
> 
> But when this generated configuration file is edited, saved, then continued
> with deployment, the deployment still uses the old generated gdeploy config
> file only, new edits are not honoured
> 
> Version-Release number of selected component (if applicable):
> --------------------------------------------------------------
> RHHI-V 1.5 ( RHV 4.2.7-1 async & RHGS 3.4.1 )
> cockpit-ovirt-dashboard-0.11.37-1
> 
> How reproducible:
> ------------------
> Always
> 
> Steps to Reproduce:
> -------------------
> 1. Start RHHI-V deployment from cockpit UI with required values
> 2. Edit the generated gdeploy configuration file from the cockpit last tab
> and save it
> 3. Continue with the deployment
> 4. Check for deployment happens as per the new edit
> 
> Actual results:
> ---------------
> Deployment happens as per the generated gdeploy configuration and new edits
> are dropped
> 
> Expected results:
> -----------------
> The new edits ( modifications ) should over-ride the generated gdpeploy
> configuration

Comment 2 Parth Dhanjal 2018-11-14 09:00:42 UTC
Hey Sas!
Do we need a functionality to edit the generated gdeploy file?
Should we remove the edit option from the review step?
The user can go back in the wizard make the changes and when the user comes back to the review step the file will be regenerated.

Comment 3 Sahina Bose 2018-12-18 07:19:33 UTC
(In reply to Parth Dhanjal from comment #2)
> Hey Sas!
> Do we need a functionality to edit the generated gdeploy file?
> Should we remove the edit option from the review step?
> The user can go back in the wizard make the changes and when the user comes
> back to the review step the file will be regenerated.

Edit functionality is needed in case of scenarios where UI does not support a feature - for instance, multiple disks in a VG

Comment 4 SATHEESARAN 2019-01-17 11:08:57 UTC
Tested with cockpit-ovirt-dashboard-0.11.38.

Editing the generated gdeploy configuration file from cockpit reflects in the actual deployment

Comment 5 Sandro Bonazzola 2019-01-22 10:23:36 UTC
This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.