Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1649655

Summary: [cockpit] Editing the generated gdeploy configuration file doesn't have effect on deployment
Product: [oVirt] cockpit-ovirt Reporter: SATHEESARAN <sasundar>
Component: GdeployAssignee: Gobinda Das <godas>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: medium Docs Contact:
Priority: medium    
Version: 0.11.29CC: bugs, dparth, godas, rhs-bugs, sabose, sankarshan, sasundar
Target Milestone: ovirt-4.2.8Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.38-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1649653 Environment:
Last Closed: 2019-01-22 10:23:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1649653, 1664044    

Description SATHEESARAN 2018-11-14 07:17:01 UTC
Description of problem:
-----------------------
While deploying RHHI-V using cockpit, the gdeploy configuration file is generated as per the user input values for hosts, volumes, and bricks.

But when this generated configuration file is edited, saved, then continued with deployment, the deployment still uses the old generated gdeploy config file only, new edits are not honoured

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHHI-V 1.5 ( RHV 4.2.7-1 async & RHGS 3.4.1 )
cockpit-ovirt-dashboard-0.11.37-1

How reproducible:
------------------
Always

Steps to Reproduce:
-------------------
1. Start RHHI-V deployment from cockpit UI with required values
2. Edit the generated gdeploy configuration file from the cockpit last tab and save it
3. Continue with the deployment
4. Check for deployment happens as per the new edit

Actual results:
---------------
Deployment happens as per the generated gdeploy configuration and new edits are dropped

Expected results:
-----------------
The new edits ( modifications ) should over-ride the generated gdpeploy configuration

Comment 1 Parth Dhanjal 2018-11-14 09:00:12 UTC
(In reply to SATHEESARAN from comment #0)
> Description of problem:
> -----------------------
> While deploying RHHI-V using cockpit, the gdeploy configuration file is
> generated as per the user input values for hosts, volumes, and bricks.
> 
> But when this generated configuration file is edited, saved, then continued
> with deployment, the deployment still uses the old generated gdeploy config
> file only, new edits are not honoured
> 
> Version-Release number of selected component (if applicable):
> --------------------------------------------------------------
> RHHI-V 1.5 ( RHV 4.2.7-1 async & RHGS 3.4.1 )
> cockpit-ovirt-dashboard-0.11.37-1
> 
> How reproducible:
> ------------------
> Always
> 
> Steps to Reproduce:
> -------------------
> 1. Start RHHI-V deployment from cockpit UI with required values
> 2. Edit the generated gdeploy configuration file from the cockpit last tab
> and save it
> 3. Continue with the deployment
> 4. Check for deployment happens as per the new edit
> 
> Actual results:
> ---------------
> Deployment happens as per the generated gdeploy configuration and new edits
> are dropped
> 
> Expected results:
> -----------------
> The new edits ( modifications ) should over-ride the generated gdpeploy
> configuration

Comment 2 Parth Dhanjal 2018-11-14 09:00:42 UTC
Hey Sas!
Do we need a functionality to edit the generated gdeploy file?
Should we remove the edit option from the review step?
The user can go back in the wizard make the changes and when the user comes back to the review step the file will be regenerated.

Comment 3 Sahina Bose 2018-12-18 07:19:33 UTC
(In reply to Parth Dhanjal from comment #2)
> Hey Sas!
> Do we need a functionality to edit the generated gdeploy file?
> Should we remove the edit option from the review step?
> The user can go back in the wizard make the changes and when the user comes
> back to the review step the file will be regenerated.

Edit functionality is needed in case of scenarios where UI does not support a feature - for instance, multiple disks in a VG

Comment 4 SATHEESARAN 2019-01-17 11:08:57 UTC
Tested with cockpit-ovirt-dashboard-0.11.38.

Editing the generated gdeploy configuration file from cockpit reflects in the actual deployment

Comment 5 Sandro Bonazzola 2019-01-22 10:23:36 UTC
This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.