Bug 16499 - comps file parser is fragile
comps file parser is fragile
Status: CLOSED RAWHIDE
Product: Red Hat Linux
Classification: Retired
Component: anaconda (Show other bugs)
7.1
i386 Linux
high Severity medium
: ---
: ---
Assigned To: Jeremy Katz
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2000-08-18 02:37 EDT by Pekka Savola
Modified: 2008-05-01 11:37 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2002-04-26 15:43:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
diff for an offending comps file (Server/Workstation copies) (737 bytes, patch)
2000-08-18 02:38 EDT, Pekka Savola
no flags Details | Diff

  None (edit)
Description Pekka Savola 2000-08-18 02:37:11 EDT
If your 'comps' file is too long (too many packages it'd
seem), the installer halts without any errors in 'reading packages'
screen.  An example of an offending comps file is attached to bugzilla.
  
It doesn't matter if those packages have been included by '@ Development'
-like classes or typed in directly.      
  
Please note that you _can_ create a couple of new classes 
(I did so for our server class, and it worked fine), but it seems there's
some magic limit out there.

This has worked fine in RH 6.0 - 6.2.                               
                       
Kind of a showstopper for us package customizers.
Comment 1 Pekka Savola 2000-08-18 02:38:22 EDT
Created attachment 2636 [details]
diff for an offending comps file (Server/Workstation copies)
Comment 2 Glen Foster 2000-08-18 16:45:30 EDT
This defect is considered MUST-FIX for Winston Gold release
Comment 3 Matt Wilson 2000-08-21 13:08:40 EDT
works for me, at least in NFS...
Comment 4 Pekka Savola 2000-08-22 01:57:31 EDT
This works in RC2; perhaps the problem was inadvertly fixed.  Did you try it
using RC1 or RC2?
Comment 5 Pekka Savola 2000-09-15 18:13:11 EDT
This also happens with Gold release.

However, I don't think comps.diff attached will show the broken behaviour.

It might be that classes included with '@' may not contain empty lines.  
Regular classes Joe User can choose can do that just fine.

Removing all empty lines from within class definitions appeared to fix this.

I didn't have time to check what's causing this very thoroughly :-(
Comment 6 Matt Wilson 2000-09-17 18:58:26 EDT
Yes, empty lines are not allowed.  The comps parser isn't exactly wonderful. :|
Comment 7 Michael Fulbright 2002-07-17 11:54:09 EDT
We use XML now should not have these issues.
Comment 8 Michael Fulbright 2002-12-20 12:38:25 EST
Time tracking values updated

Note You need to log in before you can comment on or make changes to this bug.