Description of problem: {{vm.name}} appears as a clickable button when editing hosts Version-Release number of selected component (if applicable): {{vm.name}} appears as a clickable button when editing hosts under all tabs under Endpoint except Default How reproducible: Always Steps to Reproduce: 1. Compute > Infrastructure > Hosts > Edit Host 2. Click on any tab but Default under endpoint 3. Actual results: {{ vm.name }} shows up Expected results: Validate shows up Additional info:
https://github.com/ManageIQ/manageiq-ui-classic/pull/4929
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/21dad31c3b05874ca522a05bc0858dde28d57920 commit 21dad31c3b05874ca522a05bc0858dde28d57920 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Nov 15 10:22:52 2018 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Nov 15 10:22:52 2018 -0500 Fixed if condition to prevent undefined js error Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649918 app/assets/javascripts/controllers/host/host_form_controller.js | 4 +- 1 file changed, 2 insertions(+), 2 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/fe51f086f9ca5da207701293aed0820737ac60de commit fe51f086f9ca5da207701293aed0820737ac60de Author: Harpreet Kataria <hkataria> AuthorDate: Thu Nov 15 12:24:00 2018 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Nov 15 12:24:00 2018 -0500 attempt to fix cc errors - To simplify complex logical expression & fix similar code blocks - adjusted jasmine spec tests Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649918 app/assets/javascripts/controllers/host/host_form_controller.js | 26 +- spec/javascripts/controllers/host/host_form_controller_spec.js | 6 +- 2 files changed, 13 insertions(+), 19 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/hammer: https://github.com/ManageIQ/manageiq-ui-classic/commit/d685f7bd7a14688f0428ccb3a4ff634af96d27ea commit d685f7bd7a14688f0428ccb3a4ff634af96d27ea Author: Dan Clarizio <dclarizi> AuthorDate: Fri Nov 16 15:42:48 2018 -0500 Commit: Dan Clarizio <dclarizi> CommitDate: Fri Nov 16 15:42:48 2018 -0500 Merge pull request #4929 from h-kataria/host_editor_js_undefined_error_fix Fixed if condition to prevent undefined js error (cherry picked from commit 4a3bed3b4654c359a582b1940bb4f22f4822f8f5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649918 app/assets/javascripts/controllers/host/host_form_controller.js | 26 +- spec/javascripts/controllers/host/host_form_controller_spec.js | 6 +- 2 files changed, 13 insertions(+), 19 deletions(-)
Created attachment 1510102 [details] fixed_proof.png Verified on: 5.10.0.27.20181128170555_43ed8cb Thanks!