Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1650181

Summary: DM_DEVICE_CREATE can pass unused secure table data to a resume ioctl which leaves it in memory unwiped
Product: Red Hat Enterprise Linux 8 Reporter: Zdenek Kabelac <zkabelac>
Component: lvm2Assignee: Zdenek Kabelac <zkabelac>
lvm2 sub component: libdevmapper QA Contact: cluster-qe <cluster-qe>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: unspecified    
Priority: unspecified CC: agk, cmarthal, heinzm, jbrassow, mbroz, mcsontos, msnitzer, okozina, prajnoha, prockai, rhandlin, zkabelac
Version: 8.0Flags: pm-rhel: mirror+
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lvm2-2.03.02-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-14 01:19:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zdenek Kabelac 2018-11-15 14:32:04 UTC
Description of problem:

When DM_DEVICE_CREATE is used with table, it also does automatic table load and resume. But since resume ioctl does not take parameters, it's param memory is not wipes upon exit from kernel  - user space was not meant to pass any argument here.

This bug may leak some secure data to running user space process that were meant to be cleared immediately after ioctl call.

Version-Release number of selected component (if applicable):
devicemapper library < 1.02.155 

How reproducible:


Steps to Reproduce:
1. simple test program will be provided.
2.
3.

Actual results:
data leaking in i.e. coredump of process.

Expected results:
no memory trace in address space of task.

Additional info:

Comment 1 Zdenek Kabelac 2018-11-19 16:14:31 UTC
Addressed with upstream commit:

https://www.redhat.com/archives/lvm-devel/2018-November/msg00068.html

Test cases added with (and later tuned further)

https://www.redhat.com/archives/lvm-devel/2018-November/msg00073.html

Comment 2 Marian Csontos 2018-12-19 17:15:45 UTC
Corey, is the coverage in our test suite sufficient to grant a qa-ack? This is IMO rather internal thing, which should be rather covered by unit tests (as it is now)