Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1650298

Summary: IP, MTU, and route changes should not restart interfaces (OSP-13)
Product: Red Hat OpenStack Reporter: Bob Fournier <bfournie>
Component: os-net-configAssignee: Dan Sneddon <dsneddon>
Status: CLOSED ERRATA QA Contact: Alistair Tonner <atonner>
Severity: medium Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: atonner, bfournie, dsneddon, hbrock, hjensas, jschluet, jslagle, mburns, mlammon, riontel, sasha
Target Milestone: z6Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: os-net-config-8.4.4-1.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1650296 Environment:
Last Closed: 2019-04-30 17:27:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1650296    
Bug Blocks:    

Description Bob Fournier 2018-11-15 18:49:29 UTC 
+++ This bug was initially created as a clone of Bug #1650296 +++

Description of problem:

os-net-config restarts an interface when any aspect of the configuration changes. Some changes, like IP changes, route changes, MTU, and boot settings can be set on the fly with 'ip' or 'ip route' commands. If those are the only changes, os-net-config should just make the changes to the config and run the necessary commands instead of restarting the interface.

This behavior is necessary in environments where routes may be updated during scaling operations, such as routed spine/leaf environments when adding new leaf networks.
Comment 1 Bob Fournier 2019-01-18 13:02:11 UTC 
*** Bug 1665157 has been marked as a duplicate of this bug. ***
Comment 5 Alistair Tonner 2019-03-07 16:32:23 UTC 
core puddle: 2019-03-01.1
os-net-config.noarch      8.4.3-5.el7ost 

changed MTU on tenant network:

   -
     type: vlan
     mtu: 1420
     vlan_id:
          get_param: TenantNetworkVlanID
          addresses:
          -

 ran overcloud update 

Change Applied:

ifconfig vlan50
vlan50: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1420
        inet 172.17.2.10  netmask 255.255.255.0  broadcast 172.17.2.255
        inet6 fe80::cef:7dff:fe70:7dd5  prefixlen 64  scopeid 0x20<link>
        ether 0e:ef:7d:70:7d:d5  txqueuelen 1000  (Ethernet)
        RX packets 1458  bytes 115384 (112.6 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 1427  bytes 133726 (130.5 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

ar  7 10:53:28 compute-0 os-collect-config: [2019/03/07 03:53:26 PM] [INFO] No changes required for vlan interface: vlan30
Mar  7 10:53:28 compute-0 os-collect-config: [2019/03/07 03:53:26 PM] [INFO] Running ip link set dev vlan50 mtu 1420
Mar  7 10:53:28 compute-0 os-collect-config: [2019/03/07 03:53:26 PM] [INFO] Writing config /etc/sysconfig/network-scripts/ifcfg-vlan50
Mar  7 10:56:45 compute-0 puppet-user[14]: (/Stage[main]/Neutron/Neutron_config[DEFAULT/vlan_transparent]/ensure) created


  Monitor of vlan50 while change applied showed the interface never went down

while true
do
ip link show vlan50 |grep "MULTICAST,UP,LOWER_UP"  || echo "Vlan50 down at `date`" 
sleep 1
done
Comment 6 Bob Fournier 2019-03-09 02:39:28 UTC 
Since an issue was found with the OSP-14z version of this patch, moving this fix out of VERIFIED.
Comment 9 mlammon 2019-04-16 14:13:20 UTC 
Environment:
os-net-config-8.4.4-1.el7ost.noarch


Using similar verification procedure changing mtu setting to 1420 on vlan of compute.

1. deployed latest osp13 with 3 controller, 1 compute successfully
2. make changes to mtu on vlan50
3. re-run deploy command
4. monitor and only see mtu get updates
 

mtu change
/home/stack/virt/network/three-nics-vlans/compute.yaml

add " NetworkDeploymentActions: ['CREATE','UPDATE']" 
/home/stack/virt/network/network-environment.yaml

parameter_defaults:
    NetworkDeploymentActions: ['CREATE','UPDATE']


--------

see 1420 mtu change with
/home/stack/virt/network/three-nics-vlans/compute.yaml
 
                            -
                              type: vlan
                              mtu: 1420
                              vlan_id:
                                  get_param: TenantNetworkVlanID
                              addresses:
 

(undercloud) [stack@undercloud-0 ~]$ cat overcloud_deploy.sh
#!/bin/bash

openstack overcloud deploy \
--timeout 100 \
--templates /usr/share/openstack-tripleo-heat-templates \
--stack overcloud \
--libvirt-type kvm \
--ntp-server clock.redhat.com \
-e /home/stack/virt/config_lvm.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e /home/stack/virt/hostnames.yml \
-e /home/stack/virt/nodes_data.yaml \
-e /home/stack/virt/extra_templates.yaml \
-e /home/stack/virt/docker-images.yaml \
--log-file overcloud_deployment_79.log
Comment 12 errata-xmlrpc 2019-04-30 17:27:35 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0939
Comment 13 Red Hat Bugzilla 2023-09-14 04:42:27 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days