Bug 1651020 - pesign rpm macro contains syntax error
Summary: pesign rpm macro contains syntax error
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: pesign
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-18 21:28 UTC by John Soros
Modified: 2019-03-06 09:35 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)
Proposed fix for misquote in pesign rpm macro (896 bytes, text/plain)
2018-11-18 21:28 UTC, John Soros
no flags Details

Description John Soros 2018-11-18 21:28:02 UTC
Created attachment 1507039 [details]
Proposed fix for misquote in pesign rpm macro

Description of problem:
I found this bug when trying to compile my own signed kernel. When specifying pe_signing_cert , the macro has a syntax error in it.

Version-Release number of selected component (if applicable):
# dnf info pesign
Installed Packages
Name         : pesign
Version      : 0.112
Release      : 22.fc28
Arch         : x86_64
Size         : 1.0 M
Source       : pesign-0.112-22.fc28.src.rpm
Repo         : @System
From repo    : fedora
Summary      : Signing utility for UEFI binaries
URL          : https://github.com/vathpela/pesign
License      : GPLv2
Description  : This package contains the pesign utility for signing UEFI binaries as
             : well as other associated tools.

How reproducible:
Every time


Steps to Reproduce:
Add %define pe_signing_cert in kernel.spec (might work as instructed in the rpm macro itself but I have not tested because I build with mock: rpmbuild --define "pe_signing_cert signing key for test2" -ba ...)

Actual results:
Syntax error

Expected results:
Kernel built with specified key

Additional info:

See attachment for proposed fix

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-03-06 09:35:18 UTC
I pushed a fix to dist-git. Please build the package.


Note You need to log in before you can comment on or make changes to this bug.