Bug 1651098 - dht_readdirp_cbk : Set inode for dir entries if inode is already linked.
Summary: dht_readdirp_cbk : Set inode for dir entries if inode is already linked.
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Nithya Balachandran
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-19 08:21 UTC by Nithya Balachandran
Modified: 2019-11-04 04:24 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-04 04:24:44 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 21673 0 None Abandoned cluster/dht: Set the entry->inode if dir was lookup up earlier 2019-03-04 19:31:12 UTC

Description Nithya Balachandran 2018-11-19 08:21:35 UTC 
Description of problem


dht_readdirp_cbk sets the entry->inode to NULL for directory entries in order to force a lookup. This causes a massive slowdown when listing directories which contain a lot of sub-directories.

If the inode for the directory is already present in the inode table, it implies that the inode was linked (ie, a lookup was performed already). If the inode for the directory entry is already linked, we do not need to send another lookup for the directory.




Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2018-11-19 08:46:41 UTC 
REVIEW: https://review.gluster.org/21673 (cluster/dht: Set the entry->inode if dir was lookup up earlier) posted (#1) for review on master by N Balachandran
Comment 2 Amar Tumballi 2019-06-20 04:50:04 UTC 
the above patch got abandoned due to inactivity timeout, and hence moving the bug to NEW.
Comment 3 Nithya Balachandran 2019-11-04 04:24:44 UTC 
This can cause stale data to be saved in the cache. Closing the BZ.
Note You need to log in before you can comment on or make changes to this bug.