Bug 1651655 - Rebase mingw-qemu-ga-win to qemu 3.1
Summary: Rebase mingw-qemu-ga-win to qemu 3.1
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: virtio-win
Version: 8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Yvugenfi@redhat.com
QA Contact: xiagao
URL:
Whiteboard:
: 1654306 (view as bug list)
Depends On:
Blocks: 1654306 1659244
TreeView+ depends on / blocked
 
Reported: 2018-11-20 13:55 UTC by Sameeh Jubran
Modified: 2020-02-28 07:29 UTC (History)
8 users (show)

Fixed In Version: virtio-win-1.9.7-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1654306 (view as bug list)
Environment:
Last Closed: 2019-06-14 01:54:39 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
diskmgmt (59.65 KB, image/png)
2018-12-03 07:13 UTC, xiagao
no flags Details

Description Sameeh Jubran 2018-11-20 13:55:02 UTC
Description of problem:

Currently mingw-qemu-ga-win is based on qemu 2.9.0, recently there has been multiple patches upstream, rebasing to qemu3.1 is easier to maintain than applying them.

Comment 6 lijin 2018-12-03 05:56:44 UTC
set needinfo here, please update the result once the verify is finished.

Comment 7 xiagao 2018-12-03 07:13:03 UTC
For {"execute":"guest-get-fsinfo"} cmd,can get response with this build and "disk" vlaue is not empty(while in https://bugzilla.redhat.com/show_bug.cgi?id=1565431,"disk" value is empty.)

qemu cmd line with one disk
-drive file=os.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,cache=none -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \

===for windows guest
{"execute":"guest-get-fsinfo" }
{"return": [{"name": "\\\\?\\Volume{ae720cf0-eddf-11e8-a128-806e6f6e6963}\\", "total-bytes": 4843268096, "mountpoint": "E:\\", "disk": [{"bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\?\\Volume{ae720cf0-eddf-11e8-a128-806e6f6e6963}", "target": 0}], "used-bytes": 4843268096, "type": "UDF"}, {"name": "\\\\?\\Volume{ae720cef-eddf-11e8-a128-806e6f6e6963}\\", "total-bytes": 567269376, "mountpoint": "D:\\", "disk": [{"bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\?\\Volume{ae720cef-eddf-11e8-a128-806e6f6e6963}", "target": 0}], "used-bytes": 567269376, "type": "CDFS"}, {"name": "\\\\?\\Volume{3ae19f15-0000-0000-0000-602200000000}\\", "total-bytes": 31634485248, "mountpoint": "C:\\", "disk": [{"serial": "QM00001", "bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\.\\PhysicalDrive0", "target": 0}], "used-bytes": 10244001792, "type": "NTFS"}, {"name": "\\\\?\\Volume{3ae19f15-0000-0000-0000-100000000000}\\", "mountpoint": "System Reserved", "disk": [{"serial": "QM00001", "bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\.\\PhysicalDrive0", "target": 0}], "type": "NTFS"}]}

===for linux guest with similar cmd line
{"return": [{"name": "sdb1", "mountpoint": "/boot", "disk": [{"bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": 0, "slot": 31, "domain": 0, "function": 2}, "target": 0}], "type": "xfs"}, {"name": "dm-0", "mountpoint": "/", "disk": [{"bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": 0, "slot": 31, "domain": 0, "function": 2}, "target": 0}], "type": "xfs"}]}

Could you help check if the result is correct?

windows disk manager in attachment.

Comment 8 xiagao 2018-12-03 07:13:36 UTC
Created attachment 1510811 [details]
diskmgmt

Comment 9 Sameeh Jubran 2018-12-03 10:55:28 UTC
(In reply to xiagao from comment #7)
> For {"execute":"guest-get-fsinfo"} cmd,can get response with this build and
> "disk" vlaue is not empty(while in
> https://bugzilla.redhat.com/show_bug.cgi?id=1565431,"disk" value is empty.)
> 
> qemu cmd line with one disk
> -drive file=os.qcow2,if=none,id=drive-ide0-0-0,format=qcow2,cache=none
> -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
> 
> ===for windows guest
> {"execute":"guest-get-fsinfo" }
> {"return": [{"name":
> "\\\\?\\Volume{ae720cf0-eddf-11e8-a128-806e6f6e6963}\\", "total-bytes":
> 4843268096, "mountpoint": "E:\\", "disk": [{"bus-type": "sata", "bus": 0,
> "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1,
> "function": -1}, "dev":
> "\\\\?\\Volume{ae720cf0-eddf-11e8-a128-806e6f6e6963}", "target": 0}],
> "used-bytes": 4843268096, "type": "UDF"}, {"name":
> "\\\\?\\Volume{ae720cef-eddf-11e8-a128-806e6f6e6963}\\", "total-bytes":
> 567269376, "mountpoint": "D:\\", "disk": [{"bus-type": "sata", "bus": 0,
> "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1,
> "function": -1}, "dev":
> "\\\\?\\Volume{ae720cef-eddf-11e8-a128-806e6f6e6963}", "target": 0}],
> "used-bytes": 567269376, "type": "CDFS"}, {"name":
> "\\\\?\\Volume{3ae19f15-0000-0000-0000-602200000000}\\", "total-bytes":
> 31634485248, "mountpoint": "C:\\", "disk": [{"serial": "QM00001",
> "bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1,
> "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\.\\PhysicalDrive0",
> "target": 0}], "used-bytes": 10244001792, "type": "NTFS"}, {"name":
> "\\\\?\\Volume{3ae19f15-0000-0000-0000-100000000000}\\", "mountpoint":
> "System Reserved", "disk": [{"serial": "QM00001", "bus-type": "sata", "bus":
> 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1,
> "function": -1}, "dev": "\\\\.\\PhysicalDrive0", "target": 0}], "type":
> "NTFS"}]}
> 
> ===for linux guest with similar cmd line
> {"return": [{"name": "sdb1", "mountpoint": "/boot", "disk": [{"bus-type":
> "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": 0, "slot": 31,
> "domain": 0, "function": 2}, "target": 0}], "type": "xfs"}, {"name": "dm-0",
> "mountpoint": "/", "disk": [{"bus-type": "sata", "bus": 0, "unit": 0,
> "pci-controller": {"bus": 0, "slot": 31, "domain": 0, "function": 2},
> "target": 0}], "type": "xfs"}]}
> 
> Could you help check if the result is correct?
> 
> windows disk manager in attachment.

The results seems pretty good to me. And yes the behavior is correct, we have disabled the command in the previous release as it didn't work correctly, now that it has been fixed upstream we can enable it.

Comment 10 lijin 2019-01-10 06:51:32 UTC
Hi Amnon,

Could you ack this bug?

Thanks

Comment 16 lijin 2019-01-23 07:50:16 UTC
*** Bug 1654306 has been marked as a duplicate of this bug. ***

Comment 19 xiagao 2019-01-28 06:21:13 UTC
Run critical and high priority test cases, all pass.
So verify this bug on mingw-qemu-ga-win-100.0.0.0-3.el7ev


Note You need to log in before you can comment on or make changes to this bug.