Spec URL: https://sabbaka.fedorapeople.org/cockpit-session-recording.spec SRPM URL: https://sabbaka.fedorapeople.org/cockpit-session-recording-1-1.fc28.src.rpm Description: Package provides session recording playback in Cockpit. Session are grabbed from Joural and they are recorded by tlog. Fedora Account System Username: sabbaka
- You missing a URL field: URL: https://github.com/Scribery/cockpit-session-recording - There doesn't seem to be a release upstream, either ask upstream to tag a release or package a dev snapshot: %global commit 2162092977dd3882834e2e13ee6e80e8e7fd66b4 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20181122 - Source0 must be a URL pointing to the archive Source0: %url/archive/%{commit}/%{name}-%{shortcommit}.tar.gz %prep %autosetup -n %{name}-%{commit} - changelog must contain your entry - Not needed for a noarch package: %define debug_package %{nil} - Summary/Description must be more detailed than that - Be more specific here: %{_datadir}/cockpit/session-recording %{_datadir}/metainfo/org.cockpit-project.session-recording.metainfo.xml - Validate the Appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
URL: https://github.com/Scribery/cockpit-session-recording Spec URL: https://sabbaka.fedorapeople.org/cockpit-session-recording.spec SRPM URL: https://github.com/Scribery/cockpit-session-recording/releases/download/v1/cockpit-session-recording-1-1.fc28.src.rpm Source0: https://github.com/Scribery/cockpit-session-recording/archive/v1.tar.gz Description: Provides Session Recording module for Cockpit. Provides list of recorded by tlog terminal sessions from Journal. Allows to play them in a player with various controls. Shows correlated logs which happened during session. Fedora Account System Username: sabbaka
I updated both the package and spec file. New review is required. Spec URL: https://sabbaka.fedorapeople.org/cockpit-session-recording.spec SRPM URL: https://sabbaka.fedorapeople.org/cockpit-session-recording-1-1.fc28.src.rpm Description: Package provides session recording playback in Cockpit. Session are grabbed from Joural and they are recorded by tlog. Fedora Account System Username: sabbaka Current contents of spec file: Name: cockpit-session-recording Version: 1 Release: 1%{?dist} Summary: Cockpit Session Recording License: LGPLv2+ URL: https://github.com/Scribery/cockpit-session-recording %global commit ffeec0bd364f165c73e769587eadc11d5c56864b %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20190404 Source0: https://github.com/Scribery/cockpit-session-recording/archive/v1-1.tar.gz %prep %autosetup -n %{name}-%{commit} Source: cockpit-session-recording-%{version}.tar.gz %define debug_package %{nil} %description Provides Session Recording module for Cockpit. Provides list of recorded by tlog terminal sessions from Journal. Allows to play them in a player with various controls. Shows correlated logs which happened during session. %prep %setup -n cockpit-session-recording %install %make_install %files %{_datadir}/cockpit/* %{_datadir}/metainfo/* %changelog * Thu Apr 4 2019 Kirill Glebov <kgliebov> - 1-1 - Release 1 First release. Includes logs correlation, player controls, journal remote support.
You didn't address several points of my review: - Why is there two Source now? Remove Source: cockpit-session-recording-%{version}.tar.gz - Since you tagged a release, this is not necessary anymore: %global commit ffeec0bd364f165c73e769587eadc11d5c56864b %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20190404 - Source0 should have a better name Source0: %url/archive/%{version}/%{name}-%{version}.tar.gz - %autosetup -n %{name}-%{commit} → %autosetup -n %{name}-%{version} - No: %define debug_package %{nil} Make your package noarch instead: BuildArch: noarch - Be more specific here: %{_datadir}/cockpit/session-recording %{_datadir}/metainfo/org.cockpit-project.session-recording.metainfo.xml - Validate the Appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage BuildRequires: libappstream-glib […] appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.appdata.xml - The description must be split onto multiple lines to stay below 80 characters per line - Please use a more descriptive summary
- The changelog entry comment mist start with -: * Thu Apr 4 2019 Kirill Glebov <kgliebov> - 1-1 - Release 1 - First release. Includes logs correlation, player controls, journal remote support.
Created attachment 1569935 [details] spec file Please, check the updated spec file
- Make %setup quiet with -q %setup -qn cockpit-session-recording Package approved. Please fix the aforementioned issue before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cockpit-session-recording-1-1.fc31.noarch.rpm cockpit-session-recording-1-1.fc31.src.rpm cockpit-session-recording.noarch: W: no-documentation cockpit-session-recording.src: W: spelling-error %description -l en_US tlog -> tog, log, slog cockpit-session-recording.src:20: W: setup-not-quiet cockpit-session-recording.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cockpit-session-recording