Description of problem: Cockpit webUI will spin endlessly when filtering for a rule and clicking "Add Service" but not selecting a filtered service to add. This will prevent any firewall rule manipulation via cockpit until the service is restarted vai:
systemctl restart cockpit.service
Even attempting to turn the firewall off/on will not reset the spinning UI
Version-Release number of selected component (if applicable): 8.0 (theOcho) beta
How reproducible: 100% of the time, every time
Steps to Reproduce:
1. Enable cockpit socket
2. Log in and open http://localhost:9090/network/firewall
3. Filter for any firewall rule (steam is a good one.)
4. Click "Add Service" without selecting a service to add
5. Watch the UI spin
Actual results: Firewall rule UI is blocked, spinning. Unable to modify firewall rules via cockpit without restarting cockpit service
Expected results: The UI would continue to function if the user clicks without selecting a service to enable.
As an addendum, this will occur without anything in the rule filter. Simply clicking "Add Service" with no services selected will lock out the UI.
The JS console shows an "Oops": TypeError: services.map is not a function
You don't really need to restart cockpit.service, reloading the browser page is enough.
I'll work on a fix now, thanks for the report!