1652229 – glibc: Do not use parallel make for building locales

Bug 1652229 - glibc: Do not use parallel make for building locales

Summary: glibc: Do not use parallel make for building locales

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat Enterprise Linux 8
Classification:	Red Hat
Component:	glibc
Sub Component:
Version:	8.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	8.0
Assignee:	Florian Weimer
QA Contact:	Alexandra Petlanová Hájková
Docs Contact:
URL:
Whiteboard:
Depends On:	1652228
Blocks:
TreeView+	depends on / blocked

Reported:	2018-11-21 17:51 UTC by Florian Weimer
Modified:	2023-07-18 14:30 UTC (History)
CC List:	8 users (show)
Fixed In Version:	glibc-2.28-35.el8
Doc Type:	No Doc Update
Doc Text:	undefined
Clone Of:	1652228
Environment:
Last Closed:	2019-06-14 01:57:55 UTC
Type:	Bug
Target Upstream Version:
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Description Florian Weimer 2018-11-21 17:51:15 UTC

+++ This bug was initially created as a clone of Bug #1652228 +++

localedef uses hard links to avoid storing the same data repeatedly across locales, but the hardlink groups are different depending on how the localedef invocations are scheduled by make.

This leads to differences in the generated RPM files—the column “6:19” in the first row is RPM's pseudo-inode number followed by the link count.

--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_AE.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_AE.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_AE/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_BH.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_BH.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_BH/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_DZ.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_DZ.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_DZ/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_EG.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_EG.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_EG/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_IN/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_IQ.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_IN/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_IQ.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_IQ/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_JO.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_JO.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_JO/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_KW.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_KW.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_KW/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_LB.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_LB.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_LB/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_LY.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_LY.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_LY/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_MA.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_MA.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_MA/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_OM.utf8/LC_CTYPE
+-rw-r--r-- () 300:1 {(none)} root root 337024 - /usr/lib/locale/ar_OM.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_OM/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_QA.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_QA.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_QA/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_SA.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_SA.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_SA/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_SD.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_SD.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_SD/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_SS/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_SY.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_SS/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_SY.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_SY/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_TN.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_TN.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_TN/LC_CTYPE
--rw-r--r-- () 6:19 {(none)} root root 337024 - /usr/lib/locale/ar_YE.utf8/LC_CTYPE
+-rw-r--r-- () 6:18 {(none)} root root 337024 - /usr/lib/locale/ar_YE.utf8/LC_CTYPE
 -rw-r--r-- () 19:17 {(none)} root root 288796 - /usr/lib/locale/ar_YE/LC_CTYPE

If there are fewer hardlinks as the result of these races, then installation size and RPM size increases due to data duplication.

Comment 2 Florian Weimer 2018-11-21 18:14:50 UTC

Patch posted:

https://lists.fedoraproject.org/archives/list/glibc@lists.fedoraproject.org/message/CFUU75OCFEIEVGDW3XVEVT6XWDIEZGIC/

Note You need to log in before you can comment on or make changes to this bug.