Bug 1652565 - [RFE] Unable to edit floating disk
Summary: [RFE] Unable to edit floating disk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.2.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified with 1 vote
Target Milestone: ovirt-4.4.0
: ---
Assignee: shani
QA Contact: Daniel
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-22 11:38 UTC by Gianluca Cecchi
Modified: 2020-05-20 20:03 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
In this release, it is now possible to edit the properties of a Floating Disk in the Storage > Disks tab of Administration Portal. For example, the user can edit the Description, Alias, and Size of the disk.
Clone Of:
Environment:
Last Closed: 2020-05-20 20:03:46 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4?
dmaaravi: testing_plan_complete+
rule-engine: planning_ack?
pm-rhel: devel_ack+
pm-rhel: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1748097 1 None None None 2021-01-20 06:05:38 UTC
oVirt gerrit 103221 0 'None' MERGED core: Add a VmDiskOperationParameterBase(Disk) C'tor 2020-09-14 13:55:39 UTC
oVirt gerrit 103225 0 'None' MERGED core: Add tests to UpdateVmDiskCommandTest 2020-09-14 13:55:39 UTC
oVirt gerrit 103226 0 'None' MERGED core: Use UpdateVmDiskCommand for editing floating disks 2020-09-14 13:55:38 UTC
oVirt gerrit 103227 0 'None' MERGED webadmin: Enable editing floating disks from the UI 2020-09-14 13:55:38 UTC
oVirt gerrit 103271 0 'None' MERGED restapi: Allow editing disks using the REST API 2020-09-14 13:55:38 UTC
oVirt gerrit 103365 0 'None' MERGED DiskService: Change documentation for updating disks 2020-09-14 13:55:38 UTC

Internal Links: 1748097

Description Gianluca Cecchi 2018-11-22 11:38:54 UTC
Description of problem:

Sometimes I need to modify a not assigned disk, eg change description, change alias or extend in size.
One case is when I maintain a copy of a disk with an application in a certain version of it. 
During life cycle of app I can have need to extend, modify alias name and/or description of that disk.


Version-Release number of selected component (if applicable):

4.2.7

How reproducible:

always

Steps to Reproduce:
1. Go in web admin gui 

2. go to Storage --> Disks 

3. Select a disk line

Actual results:

You can only "move", "copy" or "Download" the selected disk

Also,  in Storage --> Domains --> Domain Name --> Disks
you can only "Remove" or "Download" the selected disk

Expected results:

It could be nice the possibility, in the two menus above, to edit the disk, eg 
its Alias
its Description

but also 
Extend size by xx Gb
Disk profile

Additional info:

In summary what you can already do when you select
Compute --> Virtual Machines --> Select VMNAME --> Disks --> Select disk line
click on "Edit" button

Comment 1 Nir Soffer 2019-06-27 23:24:24 UTC
I wanted to do this many times.

Daniel, do you know why editing a floating disk is not possible?

Comment 2 Daniel Erez 2019-06-30 06:44:54 UTC
(In reply to Nir Soffer from comment #1)
> I wanted to do this many times.
> 
> Daniel, do you know why editing a floating disk is not possible?

I always wanted to implement it :) But it never got priority :/
The issue is that UpdateVmDiskCommand is expecting a VM entity.
I.e. we need to separate the logic for updating disk's properties,
and DiskVmElement properties. So the command should be refactored
to UpdateDiskCommand that supports an optional VM parameter for
editing a disk that is attached to a VM.

Comment 7 Daniel 2019-12-25 12:55:00 UTC
New feature in 4.4.X.
Feature is working both REST API and manually via web-admin.
User can edit disks such as extend disk size, change description etc'.

Checked and verified on version: 4.4.0-0.13.master.el7.

Comment 8 Sandro Bonazzola 2020-05-20 20:03:46 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.