Bug 1652858 - Service catalog item shows VMs if selected template was deleted
Summary: Service catalog item shows VMs if selected template was deleted
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.11.0
Assignee: Milan Zázrivec
QA Contact: Ganesh Hubale
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-23 10:18 UTC by Ganesh Hubale
Modified: 2019-12-12 13:35 UTC (History)
10 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:34:52 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:35:03 UTC

Comment 3 Milan Zázrivec 2018-11-29 09:56:42 UTC
Is there an appliance showing this problem?

Thanks.

Comment 9 CFME Bot 2018-12-05 13:16:41 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/9480a766800891f1c943920e8a366b4b7feabc6c
commit 9480a766800891f1c943920e8a366b4b7feabc6c
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Dec  3 06:53:11 2018 -0500
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Dec  3 06:53:11 2018 -0500

    Fix CatalogItem tree_select()

    https://bugzilla.redhat.com/show_bug.cgi?id=1652858

 app/controllers/catalog_controller.rb | 3 +-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment 10 CFME Bot 2018-12-10 16:06:38 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/7832f1ac41f7dc99d3eacafc182d41ad94afd192
commit 7832f1ac41f7dc99d3eacafc182d41ad94afd192
Author:     Martin Hradil <himdel>
AuthorDate: Wed Dec  5 08:12:05 2018 -0500
Commit:     Martin Hradil <himdel>
CommitDate: Wed Dec  5 08:12:05 2018 -0500

    Merge pull request #5030 from mzazrivec/fix_catalog_item_tree_select

    Fix CatalogItem tree_select()

    (cherry picked from commit 14e3c7f7d744d762e862494663b35aa1676e5b6b)

    https://bugzilla.redhat.com/show_bug.cgi?id=1652858

 app/controllers/catalog_controller.rb | 3 +-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment 13 CFME Bot 2018-12-19 15:32:20 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/ac07b693509bea583c35cb6b15108cfecc3a5887
commit ac07b693509bea583c35cb6b15108cfecc3a5887
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Dec 17 09:20:16 2018 -0500
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Dec 17 09:20:16 2018 -0500

    Fix CatalogItem tree_select()

    Make the fix work for reload as well.

    https://bugzilla.redhat.com/show_bug.cgi?id=1652858

 app/controllers/catalog_controller.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 14 CFME Bot 2018-12-19 16:46:42 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/2a97bd755614beb033e190963bc879727d50e8a7
commit 2a97bd755614beb033e190963bc879727d50e8a7
Author:     Martin Hradil <himdel>
AuthorDate: Wed Dec 19 10:31:56 2018 -0500
Commit:     Martin Hradil <himdel>
CommitDate: Wed Dec 19 10:31:56 2018 -0500

    Merge pull request #5096 from mzazrivec/fix_catalog_item_tree_select_2

    Fix CatalogItem tree_select()

    (cherry picked from commit 7135d3f1cc850aee6ea255b126034c92f8007130)

    https://bugzilla.redhat.com/show_bug.cgi?id=1652858

 app/controllers/catalog_controller.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 16 Milan Zázrivec 2019-01-10 07:37:52 UTC
Previous comment did not request any information, so I'm cancelling the needinfo here.

Comment 18 Milan Zázrivec 2019-01-11 09:23:47 UTC
Needinfo in bugzilla is meant to be used to request information, not to alert to
a failed bz. Should a bz fail verification, returning the status back to ASSIGNED
with an explainig comment makes it perfectly clear, it has worked for ages and
it still does.

Matter of fact, setting needinfo in that situation would seem that I owe somebody
some piece of information, when in fact no information was requested.

That is why I made the comment #16, not because it would not be clear to me, that
this bz failed the verification process at some point.

I want to thank everyone who is able to honor the process.

Comment 22 CFME Bot 2019-03-01 10:16:30 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/97547f958ac2b13f4e94cf3dddf281448593c270
commit 97547f958ac2b13f4e94cf3dddf281448593c270
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Thu Jan 24 10:27:28 2019 -0500
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Thu Jan 24 10:27:28 2019 -0500

    Fix summary screen rendering for catalog item with deleted image

    In this particular situation, @view would be set, which would confuse
    further code to render GTL instead of a summary screen.

    https://bugzilla.redhat.com/show_bug.cgi?id=1652858

 app/controllers/catalog_controller.rb | 3 +-
 app/views/catalog/explorer.html.haml | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

Comment 25 errata-xmlrpc 2019-12-12 13:34:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.