Bug 165293 - Review Request: perl-Locale-gettext
Review Request: perl-Locale-gettext
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ville Skyttä
David Lawrence
http://search.cpan.org/~pvandry/gette...
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-08-07 01:38 EDT by Ralf Corsepius
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-08-11 00:52:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ralf Corsepius 2005-08-07 01:38:08 EDT
Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Locale-gettext.spec
SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Locale-gettext-1.05-1.src.rpm

Description:
The gettext module permits access from perl to the gettext() family of
functions for retrieving message strings from databases constructed to
internationalize software.
Comment 1 Ville Skyttä 2005-08-07 05:12:53 EDT
Not a review yet, nor an objection, but just to make sure you're aware of:  
 
We already have perl-libintl in Extras, and porting/patching apps to use it  
instead of Locale-gettext is often a matter of a trivial  
 
    s/Locale::gettext/Locale::Messages/ 
 
If you'd still like to see L::g in Extras, I can review this. 
Comment 2 Ralf Corsepius 2005-08-08 02:47:00 EDT
(In reply to comment #1)
Well, I had been aware about perl-libintl, but I had not been aware of the "sed".
  
> If you'd still like to see L::g in Extras, I can review this. 
Let me put it this way, ATM, Locale::gettext to me is just a dependency of
another package. I'd prefer to leave the decision on whether to use
Locale::gettext or Locale::Messages to upstream perl.
Comment 3 Ville Skyttä 2005-08-08 10:55:46 EDT
Uh... upstream perl? 
Comment 4 Ralf Corsepius 2005-08-08 11:03:16 EDT
Locale::Message/perl-libintl and Locale::gettext apparently are competing
approaches, so unless perl decides to abandon one of each, I don't feel
legitimated nor do I think FE is legitmated to abandon on of them.
Comment 5 Ville Skyttä 2005-08-08 11:18:14 EDT
Sure, but neither is in upstream perl, so neither can be abandoned there.  You 
mean CPAN? 
 
Anyway, as said, since you're convinced that this is needed, I can review it 
later today. 
Comment 6 Ralf Corsepius 2005-08-08 11:23:32 EDT
(In reply to comment #5)
> Sure, but neither is in upstream perl, so neither can be abandoned there.  You 
> mean CPAN? 
Of cause ... nit-picking mode, today?

> Anyway, as said, since you're convinced that this is needed
Sorry, no, I am not convinced. It's just the most simple way to satisfy another
package's dependency, and to avoid having to hack this other package.

If _you_ should be convinced Locale::Message is 100% compatible to
Locale::gettext, then I'd propose somebody should add a Locale::gettext to
perl-libintl - However, too me, this sounds really dangerous.

Comment 7 Ville Skyttä 2005-08-08 15:18:35 EDT
Shrug.  
  
REWORK:  
- BuildRequires: gettext missing -> test suite coverage  
  
Cosmetics:  
- URL tag is subject to bitrot  
- Release number in latest changelog entry is off sync  
  
Comment 8 Ralf Corsepius 2005-08-09 03:25:07 EDT
Updated srpm/spec with Ville's review reflected:

Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Locale-gettext.spec
SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Locale-gettext-1.05-2.src.rpm
Comment 9 Ville Skyttä 2005-08-09 12:29:37 EDT
Approved. 

Note You need to log in before you can comment on or make changes to this bug.