Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1652940

Summary: [downstream clone - 4.2.8] NTP config is migrated to chrony on every upgrade
Product: Red Hat Enterprise Virtualization Manager Reporter: RHV bug bot <rhv-bugzilla-bot>
Component: imgbasedAssignee: Yuval Turgeman <yturgema>
Status: CLOSED ERRATA QA Contact: Huijuan Zhao <huzhao>
Severity: high Docs Contact: Rolfe Dlugy-Hegwer <rdlugyhe>
Priority: high    
Version: 4.2.6CC: chyan, cshao, dfediuck, gianluca.cecchi, huzhao, qiyuan, ratamir, rdlugyhe, sbonazzo, weiwang, yaniwang, ycui, yturgema
Target Milestone: ovirt-4.2.8Keywords: ZStream
Target Release: ---Flags: lsvaty: testing_plan_complete-
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Migrating the default ntp.conf to chrony unconditionally. Consequence: The migration overrides an existing chrony.conf with wrong values. Fix: Migrate ntp.conf only if ntp is enabled. Result: ntp.conf will be migrated to chrony.conf only if the ntp.conf is valid and ntp is running.
Story Points: ---
Clone Of: 1638606 Environment:
Last Closed: 2019-01-22 12:44:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1638606    
Bug Blocks:    

Description RHV bug bot 2018-11-23 16:05:04 UTC
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1638606 +++
======================================================================

Description of problem:

In 4.2, RHV switched from ntpd to chrony and a translator from ntpd to chrony was added (BZ1503148) to ease the transition.

However, this translator still runs with every upgrade. Even on a freshly installed host. This means on every upgrade /etc/chrony.conf is overwritten with the settings from /etc/ntp.conf, making it impossible for the user to customize /etc/chrony.conf as the settings are overwritten.

This migration should only happen once (i.e. if ntpd is enabled) not on every upgrade.

Also, the latest versions are still shipped with /etc/ntp.conf even if it is not in use.

Version-Release number of selected component (if applicable):
rhvh-4.2.6

How reproducible:
100%

Steps to Reproduce:
1. Install rhvh-4.2.6.1-0.20180907.0
2. Modify /etc/chrony.conf
3. Upgrade

Actual results:
/etc/chrony.conf modified

Expected results:
/etc/chrony.conf persisted

Additional info:

On every upgrade...
2018-10-12 13:41:48,155 [DEBUG] (migrate_ntp_to_chrony) Migrating NTP configuration to chrony
2018-10-12 13:41:48,156 [DEBUG] (migrate_ntp_to_chrony) Adding ntp option: servers

(Originally by Germano Veit Michel)

Comment 3 RHV bug bot 2018-11-23 16:05:19 UTC
Can reproduce this issue.

Test steps:
1. Install rhvh-4.2.6.1-0.20180907.0
2. Modify /etc/chrony.conf
3. Upgrade

Test result:
/etc/chrony.conf not persisted

(Originally by Chen Shao)

Comment 6 Huijuan Zhao 2018-11-29 05:41:28 UTC
This bug is fixed in redhat-virtualization-host-4.2-20181128.0

Scenario 1

Test versions:
# imgbase layout
rhvh-4.2.7.5-0.20181121.0
 +- rhvh-4.2.7.5-0.20181121.0+1
rhvh-4.2.8.0-0.20181127.0
 +- rhvh-4.2.8.0-0.20181127.0+1

Test steps:
1. Install rhvh-4.2.7.5-0.20181121.0
2. Login rhvh, check chronyd.service is active
3. Change both /etc/chrony.conf (e.g. add server1) and /etc/ntp.conf(e.g. add server2)
4. Upgrade rhvh to rhvh-4.2.8.0-0.20181127.0
5. Check chronyd.service status and /etc/chrony.conf

Test results:
After step 5, chronyd.service is active, /etc/chrony.conf only persisted the change of /etc/chrony.conf in step 3(add server1).


Scenario 2

Test versions:
# imgbase layout
rhvh-4.1-0.20180425.0
 +- rhvh-4.1-0.20180425.0+1
rhvh-4.2.8.0-0.20181127.0
 +- rhvh-4.2.8.0-0.20181127.0+1

Test steps:
1. Install rhvh-4.1-0.20180425.0
2. Login rhvh, stop chronyd.service, start ntpd.service
3. Change both /etc/chrony.conf (e.g. add server1) and /etc/ntp.conf(e.g. add server2)
4. Upgrade rhvh to rhvh-4.2.8.0-0.20181127.0
5. Check chronyd.service status and /etc/chrony.conf

Test results:
After step 5, chronyd.service is active, /etc/chrony.conf only persisted the change of /etc/ntp.conf in step 3(add server2).


So this bug is fixed, change the status to VERIFIED.

Comment 8 errata-xmlrpc 2019-01-22 12:44:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0116

Comment 9 Daniel Gur 2019-08-28 13:12:39 UTC
sync2jira

Comment 10 Daniel Gur 2019-08-28 13:16:52 UTC
sync2jira