Bug 1653666 - Review Request: golang-github-xdg-stringprep - Provides an implementation of the stringprep algorithm (RFC-3454)
Summary: Review Request: golang-github-xdg-stringprep - Provides an implementation of ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Carl George
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-27 11:33 UTC by Marek Skalický
Modified: 2018-12-03 11:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-12-03 11:35:57 UTC
Type: ---
Embargoed:
carl: fedora-review+

Attachments (Terms of Use)

Description Marek Skalický 2018-11-27 11:33:32 UTC 
Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-xdg-stringprep/golang-github-xdg-stringprep.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-xdg-stringprep/golang-github-xdg-stringprep-0-0.1.20181127git73f8eec.fc30.src.rpm
Description: This library provides an implementation of the stringprep algorithm (RFC-3454) in Go, including all data tables
Fedora Account System Username: mskalick
Comment 1 Carl George 2018-11-27 17:19:45 UTC 
There are a few minor things that need to be cleaned up.

> golang-github-xdg-stringprep-devel.noarch: W: unexpanded-macro %description -l C %{import_path}

I think you want to use %{goipath} here.

> golang-github-xdg-stringprep-devel.noarch: E: summary-too-long C This library provides an implementation of the stringprep algorithm (RFC-3454) in Go, including all data tables
> golang-github-xdg-stringprep-devel.noarch: E: description-line-too-long C This library provides an implementation of the stringprep algorithm (RFC-3454) in Go, including all data tables

Your summary is over 80 characters long, shorten it up to clear these.

> License:        MIT

https://github.com/xdg-go/stringprep/blob/master/LICENSE says Apache.
Comment 2 Marek Skalický 2018-11-28 09:28:52 UTC 
Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-xdg-stringprep/golang-github-xdg-stringprep.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-xdg-stringprep/golang-github-xdg-stringprep-0-0.2.20181128git73f8eec.fc30.src.rpm
Description: Provides an implementation of the stringprep algorithm (RFC-3454)
Fedora Account System Username: mskalick
Comment 3 Marek Skalický 2018-11-28 09:30:07 UTC 
Updated. Thanks for comments and sorry about the license - my mistake/copy-paste error.
Comment 4 Marek Skalický 2018-11-28 09:38:59 UTC 
Sorry, wrong URL. The correct one:

Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-xdg-stringprep/golang-github-xdg-stringprep.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-xdg-stringprep/golang-github-xdg-stringprep-0-0.2.20181127git73f8eec.fc30.src.rpm
Description: Provides an implementation of the stringprep algorithm (RFC-3454)
Fedora Account System Username: mskalick
Comment 5 Carl George 2018-11-28 15:20:08 UTC 
Looks good now.  PACKAGE APPROVED.
Comment 6 Igor Raits 2018-11-30 12:43:56 UTC 
How come that there are no BuildRequires for Go compiler?
Comment 7 Igor Raits 2018-11-30 12:44:54 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-xdg-stringprep
Comment 8 Marek Skalický 2018-11-30 16:45:25 UTC 
(In reply to Igor Gnatenko from comment #6)
> How come that there are no BuildRequires for Go compiler?

%gometa macro adds it.

So requires of srpm are:
 compiler(go-compiler)
 golang(golang.org/x/text/unicode/norm)
 rpmlib(CompressedFileNames) <= 3.0.4-1
 rpmlib(FileDigests) <= 4.6.0-1
Comment 9 Marek Skalický 2018-12-03 11:35:57 UTC 
Thanks for the review.
Note You need to log in before you can comment on or make changes to this bug.