Bug 165413 - Review Request: plague RPM build system
Summary: Review Request: plague RPM build system
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josh Boyer
QA Contact: David Lawrence
URL: http://people.redhat.com/dcbw/plague/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-09 03:27 UTC by Dan Williams
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2005-08-21 14:37:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dan Williams 2005-08-09 03:27:08 UTC
Spec Name or Url: http://people.redhat.com/dcbw/plague/
SRPM Name or Url: http://people.redhat.com/dcbw/plague/

See also:
http://cvs.fedora.redhat.com/viewcvs/extras-buildsys/?root=fedora
http://www.fedoraproject.org/wiki/Extras/BuildSystem

Description: plague is an RPM-based distributed build system written in python, that powers Fedora Extras builds

Comment 1 Josh Boyer 2005-08-10 01:49:47 UTC
Two initial minor issues:

1) Buildroot should be:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

to keep with the Extras packaging guidelines

2) I think the Requires: for pyOpenSSL can be dropped in all sub-packages except
plague-common since everything else already depends on plague-common.


I'll do a bit more looking and see if i notice anything else, but it looks
pretty good so far.


Comment 2 Dan Williams 2005-08-10 03:34:02 UTC
fair enough.  will respin packages and upload with these changes.


Comment 3 Josh Boyer 2005-08-10 13:35:18 UTC
I see no other issues.  The package builds and installs on both FC-3 and FC-4. 
It is obviously working since all of Extras is relying on it.

I approve this package.

Comment 4 Josh Boyer 2005-08-10 13:36:19 UTC
Oops, wrong blocker bug. :)

Comment 5 Dan Williams 2005-08-11 19:36:55 UTC
Fixes done, will be imported as plague-0.3.1-1

Comment 6 Dan Williams 2005-08-11 19:55:43 UTC
imported and building

Comment 7 Ville Skyttä 2005-08-15 20:49:05 UTC
owners.list entry in CVS (and thus Bugzilla component, I guess) still missing.   

Comment 8 Josh Boyer 2005-08-21 14:37:22 UTC
added to owners.list now.  thanks for pointing that out.


Note You need to log in before you can comment on or make changes to this bug.