Bug 1654199 - gnome-maps array.toString() relies on deprecated behavior
Summary: gnome-maps array.toString() relies on deprecated behavior
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-maps
Version: 29
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-28 09:01 UTC by Jiri Prajzner
Modified: 2019-11-06 12:24 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-06 12:24:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jiri Prajzner 2018-11-28 09:01:28 UTC
Description of problem:
gnome-maps array.toString() relies on deprecated behavior

Version-Release number of selected component (if applicable):
3.30.2.1

How reproducible:
always

Steps to Reproduce:
1. execute gnome-maps
2.
3.

Actual results:
Gjs-WARNING **: 10:00:00.158: Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array).
(Note that array.toString() may have been called implicitly.)
0 <TOP LEVEL> ["resource:///org/gnome/Maps/js/osmTypes.js":32]
1 <TOP LEVEL> ["resource:///org/gnome/Maps/js/osmEditDialog.js":35]
2 <TOP LEVEL> ["resource:///org/gnome/Maps/js/osmEdit.js":25]
3 <TOP LEVEL> ["resource:///org/gnome/Maps/js/contextMenu.js":33]
4 <TOP LEVEL> ["resource:///org/gnome/Maps/js/mainWindow.js":33]
5 <TOP LEVEL> ["resource:///org/gnome/Maps/js/application.js":35]
6 <TOP LEVEL> ["resource:///org/gnome/Maps/js/main.js":43]
7 start() ["resource:///org/gnome/gjs/modules/package.js":209]
8 <TOP LEVEL> ["/usr/bin/gnome-maps":2]

Expected results:
the obsolete behavior is removed
Additional info:

Comment 1 Kalev Lember 2018-11-28 09:07:19 UTC
Can you file this upstream at https://gitlab.gnome.org/GNOME/gnome-maps please? We don't have anyone working on gnome-maps code in Fedora, just packaging up what upstream releases.

Comment 2 Jiri Prajzner 2018-11-29 07:08:51 UTC
(In reply to Kalev Lember from comment #1)
> Can you file this upstream at https://gitlab.gnome.org/GNOME/gnome-maps
> please? We don't have anyone working on gnome-maps code in Fedora, just
> packaging up what upstream releases.

done: https://gitlab.gnome.org/GNOME/gnome-maps/issues/139

Comment 3 Ben Cotton 2019-10-31 20:19:28 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Jiri Prajzner 2019-11-06 12:24:21 UTC
seems fixed


Note You need to log in before you can comment on or make changes to this bug.