Red Hat Bugzilla – Bug 165456
Review Request: fnfx - Enables hotkey functions for Toshiba laptop
Last modified: 2007-11-30 17:11:11 EST
Spec Name or Url: http://fedora.lowlatency.de/review/fnfx.spec SRPM Name or Url: http://fedora.lowlatency.de/review/fnfx-0.3-2.src.rpm Description: FnFX enables owners of Toshiba laptops to change the LCD brightness, control, the internal fan and use the special keys on their keyboard (Fn-x combinations, hot-keys). The internal functions will give the possibility to map the Fn-Keys to functions like volume up/down, mute, suspend to disk, suspend to ram and switch LCD/CRT/TV-out. These functions heavily depend on the system and/or kernel configuration. You will need at least a kernel (v2.4.x, v2.5.x, v2.6.x) with ACPI and Toshiba support (CONFIG_ACPI and CONFIG_ACPI_TOSHIBA).
Attached is a patch to the spec file to fix minor issues. The first real blocker would have been that the _sysconfdir/fnfx/ directory was unowned by the package, thus not removed upon uninstall. The second maybe the execution bit of the init script after storing the file in CVS, as it wasn't explicitely set anywhere. Now for the init script : Things seem wrong, as if the daemon crashes, then the /var/lock/subsys/fnfxd will be left over, and given how the checks are made, it will prevent it from being started again, and even forcing a stop or restart won't get rid of the file.
Created attachment 117905 [details] Spec file patch
I still don't know about the init script but the rest is fixed: http://fedora.lowlatency.de/review/fnfx-0.3-3.src.rpm http://fedora.lowlatency.de/review/fnfx.spec
ping? I would say for the script part: Leave it as is and if problems arise find a way to fix them. I think it is ok the way it is.
No, the init script is definitely not ok the way it is. There is also a "RETVAL=$?" after "echo" (always true) instead of after the "killproc" call which will have the script return a wrong exit status in some occasions. Attached is a completely new init script. It fixes all the issues I've seen, but is completely untested, so please give it a try in case I've missed something. Note that I've enabled the service by default for runlevels 2345. This is something we don't want to do often, but for such a specific service that doesn't do any kind of network access, it should be considered ok, and will save the end user the step of manually enabling the service.
Created attachment 118000 [details] New init script
Thx for your work =) I am not into init scripts that much... http://fedora.lowlatency.de/review/fnfx-0.3-4.src.rpm http://fedora.lowlatency.de/review/fnfx.spec
Can you confirm that the init script is working? As soon as that's confirmed, I'll approve the package :-)
The script looks good (in comparison to other scripts) and does what is expected on my computer.. problem is: I don't have a toshiba laptop and this packages was actually the reason for a friend of mine not to switch to fc (yet ;) ) so this is why I initially put it up here... I will say it like this: It does not bail on anything I am doing but I can not test the real thing here.
OK, then go ahead and import the package.
Reminder: http://fedoraproject.org/wiki/Extras/NewPackageProcessMarkTwo Things are easier to track if they flow according to the process; a new submission should be closed (by the submitter) only after it's in CVS and successfully built.
Normalize summary field for easy parsing