Created attachment 1509791 [details] patch +++ This bug was initially created as a clone of Bug #1654659 +++ Description of problem: When installing puppet into a container image, it is preferable to use the systemd_ordering macro. According to https://fedoraproject.org/wiki/Packaging:Scriptlets: If a package is suitable for installation without systemd (in a container image, for example) and does not require any of the systemd mechanisms such as tmpfiles.d, then the systemd_ordering macro MAY be used instead of the systemd_requires macro. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Bogdan Dobrelya on 2018-11-29 06:20:58 EST --- It would be also very nice to have this for Fedora28. Please let me know if I have to clone this bug for that release? (Not sure what to do to the patch then, I submitted it against master of https://src.fedoraproject.org/rpms/puppet repo, and I can see no stable branches there)
Drop support for Fedora 27 and older, its obsolete any way. Please create PR in pagure. Thanks!
@Terje, thanks! I'll start wrapping my head around that pague and learning the contributing workflow now! :) Just to clarify the case for puppet w/o systemd, in TripleO (OpenStack installer) we have config-containers that run only a limited tags off puppet manifests. Like we only tell it to configure files and shoot execs, but not touch services (systemd) and packaging configuration aspects.
Created attachment 1510100 [details] final patch
Hey folks. Happy New Year! Any updates on that, is the proposed patch alright?
Hello. I'd love to receive some guidance for the next steps required for getting the patch merged. Thanks!
Note, there is no puppet can be found in https://pagure.io/browse/projects/ Is that me doing it wrong? :)
https://src.fedoraproject.org/rpms/puppet ?
Sorry, I confused you with my pagure comment, Fedora is running an pagure *instance*, its hosted as https://src.fedoraproject.org/ I don't mean the pagure project itself. Each package in Fedora is a submodule in the pagure instance, the puppet package is hosted here: https://src.fedoraproject.org/rpms/puppet You can create a pull request in this system.
Here is a PR against the master https://src.fedoraproject.org/rpms/puppet/pull-request/1
And a backport of it for the f29 branch https://src.fedoraproject.org/rpms/puppet/pull-request/2 I hope that works. Thank you for explaining the pagure magic, Terje ;)
Pushed. Thanks for patch! I added a changelog, please do that in future PRs, also remember to bump release.
puppet-5.5.6-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-035aaa739d
puppet-5.5.6-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-035aaa739d
So I checked out the package, and I can still see systemd in requirements # repoquery --requires --resolve puppet | grep systemd systemd-0:240-6.gitf02b547.fc30.i686 systemd-0:240-6.gitf02b547.fc30.x86_64 # dnf list puppet Installed Packages puppet.noarch 5.5.6-3.fc29 @ftp.icm.edu.pl_pub_Linux_fedora_linux_updates_testing_29_Everything_x86_64_ not good :(
I get different results: $ dnf repoquery --enablerepo=updates-testing --requires --resolve puppet-0:5.5.6-3.fc29.noarch bash-0:4.4.23-6.fc29.x86_64 hiera-0:3.3.1-4.fc29.noarch jruby-0:1.7.22-7.fc29.noarch libselinux-ruby-0:2.8-6.fc29.x86_64 libselinux-utils-0:2.8-6.fc29.x86_64 ruby-0:2.5.3-100.fc29.i686 ruby-0:2.5.3-100.fc29.x86_64 ruby-augeas-0:0.5.0-18.fc29.x86_64 ruby-facter-0:3.9.3-5.fc29.x86_64 ruby-libs-0:2.5.3-100.fc29.i686 ruby-libs-0:2.5.3-100.fc29.x86_64 rubygem-json-0:2.1.0-106.fc29.x86_64 rubygem-pathspec-0:0.2.1-3.fc29.noarch rubygem-rgen-0:0.7.0-7.fc29.noarch rubygem-ruby-shadow-0:2.5.0-7.fc29.x86_64 rubypick-0:1.1.1-9.fc29.noarch shadow-utils-2:4.6-4.fc29.x86_64 tar-2:1.30-6.fc29.x86_64 $ dnf repoquery --enablerepo=updates-testing --requires --resolve puppet-0:5.5.1-2.fc29 bash-0:4.4.23-6.fc29.x86_64 hiera-0:3.3.1-4.fc29.noarch jruby-0:1.7.22-7.fc29.noarch libselinux-ruby-0:2.8-6.fc29.x86_64 libselinux-utils-0:2.8-6.fc29.x86_64 ruby-0:2.5.3-100.fc29.i686 ruby-0:2.5.3-100.fc29.x86_64 ruby-augeas-0:0.5.0-18.fc29.x86_64 ruby-facter-0:3.9.3-5.fc29.x86_64 ruby-libs-0:2.5.3-100.fc29.i686 ruby-libs-0:2.5.3-100.fc29.x86_64 rubygem-json-0:2.1.0-106.fc29.x86_64 rubygem-pathspec-0:0.2.1-3.fc29.noarch rubygem-rgen-0:0.7.0-7.fc29.noarch rubygem-ruby-shadow-0:2.5.0-7.fc29.x86_64 rubypick-0:1.1.1-9.fc29.noarch shadow-utils-2:4.6-4.fc29.x86_64 systemd-0:239-9.gite339eae.fc29.i686 systemd-0:239-9.gite339eae.fc29.x86_64 tar-2:1.30-6.fc29.x86_64 Seems fixed to me.
Thank you for testing this Terje! That's something wrong on my side then it seems :)
Unfortunately, we have to revert because of https://github.com/rpm-software-management/dnf/pull/1315#issuecomment-462321911
Reverts proposed for puppet master https://src.fedoraproject.org/rpms/puppet/pull-request/3, f29 https://src.fedoraproject.org/rpms/puppet/pull-request/4
puppet-5.5.6-5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-066a6723b5
puppet-5.5.6-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-066a6723b5
puppet-5.5.6-5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
Reworked for master https://src.fedoraproject.org/rpms/puppet/pull-request/5
Note, for downstream-only, it has been accidently fixed already, see https://brewweb.engineering.redhat.com/brew/rpminfo?rpmID=6775664 :)
I did a modified version: https://src.fedoraproject.org/cgit/rpms/puppet.git/commit/?id=f04e1ae2d44629a2d89df0ee1a1da0d53f3550d7 https://koji.fedoraproject.org/koji/buildinfo?buildID=1226327 it avoids adding two new packages (one new package is enough) and sets conflicts to get upgrades correct. Seems like URL above is not reachable?
@Terje, the links above loog good. Thank you for the solution, it works perfectly fine! Mind updating the bug status please, like posting a link to the patch or set it to POST, if merged?
puppet-5.5.10-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-809349a09a
puppet-5.5.10-4.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-12399acdc5
puppet-5.5.10-4.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a1fa9b7403
puppet-5.5.10-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a1fa9b7403
puppet-5.5.10-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-809349a09a
puppet-5.5.10-4.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-12399acdc5
puppet-5.5.10-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
puppet-5.5.10-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
puppet-5.5.10-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.