Spec Name or Url: http://fedora.lowlatency.de/review/wmacpi.spec SRPM Name or Url: http://fedora.lowlatency.de/review/wmacpi-1.34-1.src.rpm Description: This is a port of WMApm 1.1 with ACPI support
Could you please improve the summary and description of the packages? It was very difficult to me to know what it did other than reading the included files. Believe me or not that is my main complain with the spec file. :-) One other nitpick, please add a blank line over %clean, just to increase the readability of the spec file. You could also replace the version number by %{version} in the %{source} line as well as using %{?dist} in the release file.
The spec file is missing one BR: xorg-x11-libs or else you cann't link with X11.
I will add dist later after importing. xorg-x11-libs is not needed because it gets pulled in from BR: xorg-x11-devel. Other than that: http://fedora.lowlatency.de/review/wmacpi-1.34-2.src.rpm http://fedora.lowlatency.de/review/wmacpi.spec
You are right about the building requirement, it was my mistake I misunderstood a problem I had using mock to generate the package in x86_64. Mock fails because in the makefile we have: LDFLAGS = $(OPT) -L/usr/X11R6/lib -lX11 -lXpm -lXext As you can see this is will fail for 64 bits where the right path ends with lib64. Notice also that OPT is used here, this is a bug from the original package. We do not optimize when linking, do we? That is an honest question, but even if you do I would expect it to be the same as the remaining Makefile.
done http://fedora.lowlatency.de/review/wmacpi-1.34-3.src.rpm http://fedora.lowlatency.de/review/wmacpi.spec
+ Builds inside mock on x86_64 + rpmlint output: W: wmacpi no-version-in-last-changelog I guess that is due to the version being in the next line. Easy to fix. + package name follows rules + the spec file is named correctly, it is written in English and it is legible + the license is correct (GPL), the same as upstream and it is included in %doc + The source file matches upstream. (sha1sum) + BR are correct + there are no locales, %post*, devel or doc subpackages to worry about + the package is not relocatable + there is no directory to be owned, and file permissions are correct I still do not like the description, I would expect something like (I took this from the web page with some small changes): This is a typical laptop ACPI dockapp. One interesting feature is the "timer" mode, where you can keep track of how long the laptop has been "on battery". This is opposite of the information usually provided by the BIOS, which is "time remaining", and in many cases wrong. This option can be toggled at run-time. System messages scroll on the bottom of the window, AC plug flashes when battery is charging, and green LED inside the big button flashes red if battery level is critical low. I think that the word laptop is also missing in the the Summary field, I think that you agree that this is only usefull for laptops. I am not aware of any desktop with an included battery. ;-) UPS does not count as such, at least for this program scope :-). I noticed that this program does not give any reliable information if you have two battery plugs and only the second one is present. But this is an upstream issue. The package is APPROVED.
Thx for the review... issues fixed... :)
Reopening bug to fix assignee.
Assignee fixed, closing again.
Normalize summary field for easy parsing
I would like to have that package in EL-4 and EL-5. Would you like to maintain it in EL, and if not could I do it?
Fine by me. Feel free to maintain it and add me as a co-maintainer, should be very low profile...
Package Change Request ====================== Package Name: wmacpi New Branches: EL-4 EL-5 Updated EPEL Owners: pertusus, awjb
cvs done.