http://cachalot.mine.nu/4/SRPMS/dumpasn1-20050404-0.1.src.rpm dumpasn1 is an ASN.1 object dump program that will dump data encoded using any of the ASN.1 encoding rules in a variety of user-specified formats.
Good: - rpmlint is happy - name ok - spec name ok - packaging guidelines met - license ok - license matches actual license in package - license file in %doc - spec file in American English - spec file legible - source matches upstream - locale handling ok - BuildRequires ok - builds, installs, runs, and uninstalls cleanly - builds in mock Minor nit: there are a few warnings, but nothing serious. - files stuff: ok - clean section ok - macro useage pretty ok Minor nit: in Source0, Source1, and Patch0 you sometimes use %{name} and sometime use dumpasn1 directly. I think you should use %{name} everywhere... - package contains code - %doc is only doc Approved. Cheers, Christian
Thanks for the review. Macro usage tweaked a bit in CVS, devel built successfully, will request a FC-4 branch in a jiffy and a build later.
You are welcome. BTW, forgot to ask: Is there any reason for the CC="%{__cc}" on the make line ?
Not really, I think it's a relic from the times I first did this package and the Debian patch was not yet applied (ie. no Makefile).