Fedora Account System
Red Hat Associate
Red Hat Customer
Spec: perl-Unix-Statgrab.spec SRPM Url: perl-Unix-Statgrab-0.03-3.src.rpm Description: Unix::Statgrab is a wrapper for libstatgrab as available from <http://www.i-scream.org/libstatgrab/>. It is a reasonably portable attempt to query interesting stats about your computer. It covers information on the operating system, CPU, memory usage, network interfaces, hard-disks etc. Each of the provided functions follow a simple rule: It never takes any argument and returns either an object (in case of success) or "undef". In case "undef" was returned, check the return value of "get_error". Also see "ERROR HANDLING" further below.
*** Bug 165532 has been marked as a duplicate of this bug. ***
Pasting the URLs from Bug 165532 here: Spec Url: http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/perl-Unix-Statgrab SRPM Url: http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/perl-Unix-Statgrab
*** Bug 165685 has been marked as a duplicate of this bug. ***
Created attachment 117996 [details] Updated SRPM addressing review issues Review: - rpmlint clean - package and specfile naming OK - package meets guidelines - license is LGPL - specfile written in English and is reasonably legible - sources match upstream - package builds OK on FC4 and in mock for rawhide (i386) - no libraries, subpackages, locales, pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage reasonably consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - BR: perl is redundant - Add BR: perl(Test::Pod), perl(Test::Pod::Coverage) to improve test coverage - Not much point having `Also see "ERROR HANDLING" further below' as the last sentence of %description; I'd suggest dispensing with the second paragraph entirely - Current files list results in "file listed twice" warnings at build time - License is LGPL, not Artistic - License text not included in package; I'd suggest adding Source1 as http://www.fsf.org/licensing/licenses/lgpl.txt, append "%{__cp} -p %{SOURCE1} LGPL" to %setup and adding LGPL as %doc Nitpick: - "|| :" after %check is redundant - Use of "pkgname" macro is detrimental to readability - Inconsistent indentation of tags (at least with tabs set to 8) - URL of http://search.cpan.org is rather generic; I'd suggest http://search.cpan.org/dist/Unix-Statgrab/ instead - I suggest adding Changes and README as %doc Attached SRPM addresses all of these issues. If you're OK with these changes, I'll approve the package.
If integrated everything, but renamed LGPL to LICENSE.txt. Will import this in a sec... Thanks for your review.
Changed summary for tracking purposes.