Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Sort-Versions.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Sort-Versions-1.5-2.src.rpm Description: Sort::Versions allows easy sorting of mixed non-numeric and numeric strings, like the 'version numbers' that many shared library systems and revision control packages use. This is quite useful if you are trying to deal with shared libraries. It can also be applied to applications that intersperse variable-width numeric fields within text. Other applications can undoubtedly be found.
Everything seems fine, except the License. Are you sure about 'GPL or Artistic'? I believe it's only Artistic.
From http://search.cpan.org/~edavis/Sort-Versions-1.5/Versions.pm [..] Copyright (c) 1996, Kenneth J. Albanowski. All rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. [..] => Artistic or GPL
Allright. Makes sense. Package is OK.
Review: - rpmlint clean - naming of package and spec meets guidelines - package meets guidelines - license same as perl - spec file written in English and is legible - source matches upstream - package builds ok in FC4 and in mock for devel (i386) - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership issues - no duplicate files - permissions are fine - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime Issues: - rpmlint not clean: E: perl-Sort-Versions non-executable-script /usr/lib/perl5/vendor_perl/5.8.6/Sort/Versions.pm 0644 This script is not executable I believe this is a spurious error caused by the shebang at the start of the file, but you could get rid of it anyway by appending to %prep: %{__perl} -ni -e 'print if (2 .. eof());' Versions.pm or something equivalent. - suggest adding README as %doc - BR: perl redundant - Finding empty .bs files not needed for noarch package These can be addressed post-CVS. I'm happy with this. Approved.
(In reply to comment #4) > Review: > > - rpmlint clean I did of course mean "rpmlint *not* clean - see below... Paul.
Package Change Request ====================== Package Name: perl-Sort-Versions New Branches: EL-4 Owners: pghmcfc laxathom InitialCC: perl-sig Branch approved by corsepiu in private mail, EL-5 branch maintainer added as co-maintainer.
cvs done.