Bug 1655909 - Review Request: perl-Syntax-Keyword-Try - try/catch/finally syntax for perl
Summary: Review Request: perl-Syntax-Keyword-Try - try/catch/finally syntax for perl
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1655567
TreeView+ depends on / blocked
 
Reported: 2018-12-04 09:04 UTC by Jitka Plesnikova
Modified: 2018-12-04 11:28 UTC (History)
2 users (show)

Fixed In Version: perl-Syntax-Keyword-Try-0.09-1.fc30
Clone Of:
Environment:
Last Closed: 2018-12-04 11:28:22 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2018-12-04 09:04:34 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Syntax-Keyword-Try/perl-Syntax-Keyword-Try.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Syntax-Keyword-Try/perl-Syntax-Keyword-Try-0.09-1.fc30.src.rpm
Description:
This module provides a syntax plugin that implements exception-handling
semantics in a form familiar to users of other languages, being built on a
block labeled with the try keyword, followed by at least one of a catch or
finally block.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2018-12-04 09:35:20 UTC
The Url and Source0 addresses are Ok.
A Source0 archive (SHA-256: afe51d576bb57eef247accaa656f8f34418a5289657ca40c4613087b344e2091) is original. Ok.
A summary verified from lib/Syntax/Keyword/Try.pm. Ok.
A description verified from lib/Syntax/Keyword/Try.pm. Ok.
A license verified from lib/Syntax/Keyword/Try.xs, lib/Syntax/Keyword/Try.pm, LICENSE. Ok.
BuildRequires are Ok.
All tests pass. Ok.

$ rpmlint perl-Syntax-Keyword-Try.spec ../SRPMS/perl-Syntax-Keyword-Try-0.09-1.fc30.src.rpm ../RPMS/x86_64/perl-Syntax-Keyword-Try-*
perl-Syntax-Keyword-Try.src: W: summary-not-capitalized C try/catch/finally syntax for perl
perl-Syntax-Keyword-Try.x86_64: W: summary-not-capitalized C try/catch/finally syntax for perl
4 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Syntax-Keyword-Try-0.09-1.fc30.x86_64.rpm
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib/.build-id
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib/.build-id/8d
lrwxrwxrwx    1 root    root                       70 Dec  4 10:26 /usr/lib/.build-id/8d/5e05056f2d459801d09983ab95a83d8e84a047 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Try/Try.so
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/Syntax
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/Syntax/Keyword
-rw-r--r--    1 root    root                    10697 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/Syntax/Keyword/Try.pm
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Try
-rwxr-xr-x    1 root    root                    23232 Dec  4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Try/Try.so
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/share/doc/perl-Syntax-Keyword-Try
-rw-r--r--    1 root    root                     2054 Nov  8  2017 /usr/share/doc/perl-Syntax-Keyword-Try/Changes
-rw-r--r--    1 root    root                    10128 Nov  8  2017 /usr/share/doc/perl-Syntax-Keyword-Try/README
drwxr-xr-x    2 root    root                        0 Dec  4 10:26 /usr/share/licenses/perl-Syntax-Keyword-Try
-rw-r--r--    1 root    root                    18418 Nov  8  2017 /usr/share/licenses/perl-Syntax-Keyword-Try/LICENSE
-rw-r--r--    1 root    root                     5852 Dec  4 10:26 /usr/share/man/man3/Syntax::Keyword::Try.3pm.gz
File permissions and locations are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Syntax-Keyword-Try-0.09-1.fc30.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Carp)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Syntax-Keyword-Try-0.09-1.fc30.x86_64.rpm | sort -f | uniq -c
      1 perl(Syntax::Keyword::Try) = 0.09
      1 perl-Syntax-Keyword-Try = 0.09-1.fc30
      1 perl-Syntax-Keyword-Try(x86-64) = 0.09-1.fc30
Binary provides are Ok.

Package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=31262160). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 2 Igor Raits 2018-12-04 10:42:45 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-Try

Comment 3 Jitka Plesnikova 2018-12-04 11:28:22 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.