commit cb99e112b9421f6fe98b4ac5ab5885c28ee958c3 (HEAD -> DOGTAG_10_5_BRANCH, bug1653863-CMC-tools-keyID)
Author: Christina Fu <cfu>
Date:   Fri Nov 9 11:06:57 2018 -0800

    bug 1653863 tools supporting CMC requests output keyID needs to be captured in file
    
    This patch adds code in both CRMFPopClient and PKCS10Client to automatically
    write the private key id into a file named <output>.keyId so that
    they can be featched later for CMCRequest
    <output>is the name of the file specified with the "-o" option.
    
    This patch also changed all references from "CMC self-test" to
    "CMC shared secret" instead.
    
    A test feature is also added to CMCRequest.
    
    fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655951
    
    Change-Id: Iaf2772be54f9937da456655cdec688f13f6e8b71

Testing procedure:

To test changes to CRMFPopClient, run and see if it writes the private key into a file.  e.g.

# CRMFPopClient -d . -p mypass -n "cn=Christina Fu, uid=user1a, ou=yesPOP" -q POP_SUCCESS -b kra.transport -a ec -v -o crmf.pop.req
...
Keypair private key id: 5678a18f83b7f8c4e33339889492fffe736dd3a7
...
Storing CRMF request into crmf.pop.req
Storing CRMF request key id into crmf.pop.req.keyId
# cat crmf.pop.req.keyId
5678a18f83b7f8c4e33339889492fffe736dd3a7

(compare and see if the content of crmf.pop.req.keyId is the same as the output on command line)

===
Same thing with testing PKCS10Client. e.g.
PKCS10Client -d . -p netscape -a ec -c nistp256 -o p10-ec.req -n "CN=cfuEC"
...
Keypair private key id: -50988bef7933b6e76feb65ef15284c94bf50e676
...
PKCS10Client: done. Certificate request written into p10-ec.req
PKCS10Client: PKCS#10 request key id written into p10-ec.req.keyId

# cat p10-ec.req.keyId
-50988bef7933b6e76feb65ef15284c94bf50e676
(compare and see if the content of crmf.pop.req.keyId is the same as the output on command line)

===
Testing for the changes from "self-sign" to "shared secret" (note: there was a typo in the checkin message that calls it "self-test").
The "request.selfSign" directive has been changed to "request.useSharedSecret" for CMCRequest.

* on the command line, PKCS10Client, CRMFPopClient, and CMCRequest, all references of "self-sign" (and varies other spellings) have been changed to "shared secret" (with varies spellings).
* on Man pages, both PKCS10Client and CMCRequest are changed as well.
* two profile names are changed:
caECFullCMCSelfSignedCert.cfg ==> caECFullCMCSharedTokenCert.cfg
caFullCMCSelfSignedCert.cfg ==> caFullCMCSharedTokenCert.cfg
where a constraint name is also changed:
CMCSelfSignedSubjectNameConstraint ==> CMCSharedTokenSubjectNameConstraint

===
The "test feature" that was added to CMCRequest does not need to be tested.  It was developed specifically for Gossamer.

changes needed for Guidance doc is tracked separately by the following Trello card:
https://trello.com/c/5p31gbTr/368-cc-doc-replace-cmc-self-sign-references-with-shared-secret

I'm putting this bug on "POST" (given that the guidance doc changes is tracked and will be complete soon)

DOGTAG_10_5_9_RHEL_BRANCH:

commit 253f16813de60b1951b769a437c92322e36647bf
Author: Christina Fu <cfu>
Date:   Fri Nov 9 11:06:57 2018 -0800

    bug 1653863 tools supporting CMC requests output keyID needs to be captured 
    
    This patch adds code in both CRMFPopClient and PKCS10Client to automatically
    write the private key id into a file named <output>.keyId so that
    they can be featched later for CMCRequest
    <output>is the name of the file specified with the "-o" option.
    
    This patch also changed all references from "CMC self-test" to
    "CMC shared secret" instead.
    
    A test feature is also added to CMCRequest.
    
    fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655951
    
    Change-Id: Iaf2772be54f9937da456655cdec688f13f6e8b71
    (cherry picked from commit cb99e112b9421f6fe98b4ac5ab5885c28ee958c3)

doc text looks fine.

Verified this BZ using steps which are mentioned in #c3.

1. CRMFPopClient and PKCS10Client stores the password in testuser.req.KeyID
2. Man pages and command help messages are updated for CMCRequest.
3. Mentioned profiles are replaced
   - caECFullCMCSelfSignedCert.cfg -> caECFullCMCSharedTokenCert.cfg
   - caFullCMCSelfSignedCert.cfg -> caFullCMCSharedTokenCert.cfg
4. Profile constraint changed from CMCSelfSignedSubjectNameConstraint to CMCSharedTokenSubjectNameConstraint.


Verifying this Bugzilla.

Version: 10.5.9-10.el7_6

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0168