Bug 1656100 - configure.ac does not enforce automake --foreign
Summary: configure.ac does not enforce automake --foreign
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: 5
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-12-04 17:03 UTC by Eli Schwartz
Modified: 2019-03-25 16:32 UTC (History)
1 user (show)

Fixed In Version: glusterfs-6.0
Clone Of:
Environment:
Last Closed: 2019-03-25 16:32:33 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 21799 0 None Merged configure.ac: fix option to stop automake aborting on pointless error 2018-12-05 03:42:56 UTC

Description Eli Schwartz 2018-12-04 17:03:39 UTC
Running autoreconf -fi returns an error because autotools by default tries to check everything according to the overly strict rules of a GNU package (verifying numerous inconsequential things including the presence of a non-markdown README file).

This was incorrectly worked around by manually passing the --foreign flag to a hand-coded automake invocation, rather than allowing autotools to be natively aware of the option by specifying it within the configure.ac

Anyways autogen.sh is recommended against by the GNU developers, who want people to use autoreconf (which they wrote explicitly to get away from the need to have complex autogen.sh files and instead consolidate logic where it belongs). Unfortunately, due to the lack of the build system properly setting options, said preferred mechanism does not even work.

automake needs to know about the "foreign" strictness regardless of how it is invoked.

Comment 1 Worker Ant 2018-12-04 17:08:17 UTC
REVIEW: https://review.gluster.org/21799 (configure.ac: fix option to stop automake aborting on pointless error) posted (#1) for review on master by None

Comment 2 Worker Ant 2018-12-05 03:42:54 UTC
REVIEW: https://review.gluster.org/21799 (configure.ac: fix option to stop automake aborting on pointless error) posted (#1) for review on master by None

Comment 3 Shyamsundar 2019-03-25 16:32:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.