Red Hat Bugzilla – Bug 165615
Review Request: perl-Text-Template - Expand template text with embedded Perl
Last modified: 2007-11-30 17:11:11 EST
Spec Name or Url:
SRPM Name or Url:
Summary : Expand template text with embedded Perl
This is a library for generating form letters, building HTML pages, or
filling in templates generally. A 'template' is a piece of text that
has little Perl programs embedded in it here and there. When you
'fill in' a template, you evaluate the little programs and replace
them with their values.
- rpmlint clean
- naming of package and spec is fine
- meets packaging guidelines
- license is same as perl, text included in package
- spec file written in English and is legible
- sources match upstream
- builds ok on FC4 and in mock for devel
- no locale data, libraries, pkgconfig, subpackages etc. to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- permissions OK
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
BuildRequires: perl >= 1:5.6.1
perl is listed as being part of the minimal build environment in the packaging
guidelines, so this BR appears to be redundant. The explicit version requirement
doesn't seem to comes from the module itself.
" || :" after %check isn't really needed for an Extras package, unless you're
aiming for backwards specfile compatibility with legacy distros.
*** Bug 166710 has been marked as a duplicate of this bug. ***
(In reply to comment #1)
> BuildRequires: perl >= 1:5.6.1
> perl is listed as being part of the minimal build environment in the packaging
> guidelines, so this BR appears to be redundant. The explicit version requirement
> doesn't seem to comes from the module itself.
As you said it is redundant (not a blocker). The explicit perl version comes
from the old Fedora.US template. IIRC it is related to vendor directories.
> " || :" after %check isn't really needed for an Extras package, unless you're
> aiming for backwards specfile compatibility with legacy distros.
Also from old Fedora.US/Extras perl template. I have already changed my perl
specfile generation script to not include it. Future new perl module specfiles
won't have it (present ones still have it).
I'm happy enough with this to approve it, but please do tidy it up in CVS :-)
OK. I will update it in CVS.
But the other 40+ perl modules I maintain it will take much longer ;)
456 (perl-Text-Template): Build on target development succeeded.