Created attachment 1511678 [details] Patch to fix described bugs Description of problem: A) When running backup manager with some exclude patterns which expand to multiple values (either through wildcards, or with spaces), the script prints "expr: syntax error" (in the 2 occurrences of "expr" in __get_flags_relative_blacklist()), and backups may be empty B) When running manually when backups have already been performed for a day, the error "/usr/share/backup-manager/backup-methods.sh: line 699: continue: only meaningful in a `for', `while', or `until' loop" is seen Version-Release number of selected component (if applicable): backup-manager-0.7.10-22.fc27.noarch (Note I was about to upgrade to F29, but noticed my backups were incomplete; I see the same version is in F29 though so I expect the same bug is present) How reproducible: Every time. Steps to Reproduce: 1. In my config file /etc/backup-manager.conf, BM_TARBALL_BLACKLIST contains the patterns "/home/*/tmp" and "/home/me/VirtualBox?VMs" - which represent directories I wish to exclude. Also BM_TARBALL_TARGETS[0]="/home". 2. Run backup-manager and observe "expr: syntax error" is printed repeatedly. My backup of /home is empty. 3. Run backup-manager again (it will refuse to overwrite existing backups by default) and observe "/usr/share/backup-manager/backup-methods.sh: line 699: continue: only meaningful in a `for', `while', or `until' loop" Actual results: Errors, empty backup Expected results: No errors, complete backup Additional info: Patch attached. This simply adds quotes where needed to prevent unwanted expansions into multiple values, and removes the extraneous "continue". I haven't checked but there is a later upstream release which may contain these fixes; see bug 1276791.
Issue A has a patch upstream (not yet merged): https://github.com/sukria/Backup-Manager/pull/117 Having re-read the code, I can't understand issue B - I think the original syntax is valid! The patch does make the error go away though.
This message is a reminder that Fedora 29 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '29'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 29 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.