Bug 165659 - Review Request: perl-Test-LongString
Summary: Review Request: perl-Test-LongString
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Test-Long...
Depends On:
Blocks: FE-ACCEPT 165906
TreeView+ depends on / blocked
Reported: 2005-08-11 09:14 UTC by Ralf Corsepius
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Clone Of:
Last Closed: 2005-08-20 01:48:55 UTC

Attachments (Terms of Use)

Description Ralf Corsepius 2005-08-11 09:14:32 UTC
Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-LongString.spec
SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-LongString-0.08-1.src.rpm

This module provides some drop-in replacements for the string comparison
functions of Test::More, but which are more suitable when you test against
long strings. If you've ever had to search for text in a multi-line string
like an HTML document, or find specific items in binary data, this is the
module for you.

Comment 1 Paul Howarth 2005-08-19 11:55:44 UTC

- rpmlint clean
- package and spec file naming is OK
- package meets guidelines
- license is same as perl
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime


- BR: perl is redundant
- find of empty .bs files is redundant

These can be fixed post-import.


- I think "A library to test long strings" would be a better summary than
  "Tests strings for equality"


Note You need to log in before you can comment on or make changes to this bug.