Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Regexp-Common.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Regexp-Common-2.120-1.src.rpm Description : Regexp::Common - Provide commonly requested regular expressions
Review: - rpmlint not quite clean - see below - package and spec file naming is OK - package meets guidelines - license is Artistic (only) - spec file written in English and is legible - source matches upstream - builds OK on FC4 and in mock for devel - BR's OK - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime Issues: - rpmlint output W: perl-Regexp-Common incoherent-version-in-changelog 1.120-1 2.120-1 Your last entry in %changelog contains a version that is not coherent with the current version of your package. This is just a typo in both of the specfile changelog entries. - BR: perl is redundant - find of empty .bs files is redundant - suggest for %files: %{perl_vendorlib}/Regexp/ rather than %{perl_vendorlib}/* These can be fixed post-import. Approved.