Created attachment 1512018 [details]
vm1.xml

Description of problem:
---Problem Description---
VMXML( numa cell )validation does not fail if maxvcpu vs total cpus in numa cellid does not match
  
---Steps to Reproduce---
 1. Define a vm(vm1) with two numa cell with 2 vcpus each with maxvcpus as 4

<vcpu placement='static' current='2'>4</vcpu>
<cpu>
    <topology cores="4" sockets="1" threads="1" />
    <numa>
      <cell id='0' cpus='0-1' memory='4194304' unit='KiB'/>
      <cell id='1' cpus='2-3' memory='4194304' unit='KiB'/>
    </numa>
  </cpu>

2. edit vm xml to increase the max vcpus
virsh edit vm1

<vcpu placement='static' current='2'>40</vcpu>
<cpu>
    <topology cores="40" sockets="1" threads="1" />
     <numa>
      <cell id='0' cpus='0-1' memory='4194304' unit='KiB'/>
      <cell id='1' cpus='2-3' memory='4194304' unit='KiB'/>
    </numa>
  </cpu>

3. Save the changes, vm xml saved ----NOK

Expected: VM XML validation should throw an error as numa cell's cpu range mismatch with maxvcpu


Version-Release number of selected component (if applicable):
Env:
Host Kernel: 4.20.0-rc4-gb5bd23361
#libvirtd -V
libvirtd (libvirt) 5.0.0
HW: power8 ppc64le