Spec Name or Url: http://filelister.linux-kernel.at/downloads/packages/FC_EXTRAS_APPROVAL/perl-YAML-Parser-Syck/YAML-Parser-Syck.spec SRPM Name or Url: http://filelister.linux-kernel.at/downloads/packages/FC_EXTRAS_APPROVAL/perl-YAML-Parser-Syck/perl-YAML-Parser-Syck-0.01-3.src.rpm Description: libsyck is a *gift* from a gifted Stiff named 'Why'. YAML::Parser::Syck is an XS module that binds libsyck to Perl.
Review: - rpmlint clean - package naming OK - package meets guidelines - license is same as perl - spec file written in English and is legible - sources match upstream - package builds OK in FC4 and in mock for rawhide (i386) - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - spec file should be perl-YAML-Parser-Syck.spec, not YAML-Parser-Syck.spec - redundant BR: perl - missing BR: syck-devel - license is same as perl, i.e. dual GPL/Artistic, not just Artistic - license text not included - package is arch-specific so you should be using perl_vendorarch, not perl_vendorlib - %clean should unconditionally remove the buildroot Nitpick: - what does that %description mean? "libsyck is a *gift* from a gifted Stiff named 'Why'." - I suggest manually expanding the %pkgname macro in your spec file to improve clarity - http://search.cpan.org/dist/YAML-Parser-Syck/ would be a better URL - "|| :" after %%check is redundant in Fedora Extras - compiler optimiztion flags setup could be simplified to: %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" %{__make} %{?_smp_mflags} - include "Changes" as %doc - if using macros for commands, e.g. %{__make}, be consistent about it and use them everywhere
Created attachment 118555 [details] Patch addressing review issues
Patch applied. May I have your 'approved' word? :-)
(In reply to comment #3) > Patch applied. May I have your 'approved' word? :-) With the patch, yes. Any comment on the %description?
Ping Oliver; this package has been approved for nearly 4 months.
This package appears to be orphaned without having made it into cvs...
Uupps... I'll import it tomorrow...
Package is built; can this one be closed now?