Description of problem: Settings page allows the user to set a value of "0" for Maximum concurrent migrations per conversion host. This should not be allowed. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
GitHub PR: https://github.com/ManageIQ/manageiq-v2v/pull/818
https://github.com/ManageIQ/manageiq-v2v/pull/825
Replacement PR: https://github.com/ManageIQ/manageiq-v2v/pull/825 The original PR above needed a rebase, and broke CI on master... we reverted it and replaced it with this one.
New commit detected on ManageIQ/manageiq-v2v/master: https://github.com/ManageIQ/manageiq-v2v/commit/eee6dcd70c349e55fa0d79136f080fed909c8827 commit eee6dcd70c349e55fa0d79136f080fed909c8827 Author: Mike Turley <mturley> AuthorDate: Thu Dec 6 13:15:06 2018 -0500 Commit: Mike Turley <mturley> CommitDate: Thu Dec 6 13:15:06 2018 -0500 Settings: enforce a minimum of 1 migration per conversion host https://bugzilla.redhat.com/show_bug.cgi?id=1656961 app/javascript/react/screens/App/Settings/Settings.js | 1 + app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap | 1 + app/javascript/react/screens/App/common/forms/NumberInput.js | 13 +- 3 files changed, 12 insertions(+), 3 deletions(-)
New commits detected on ManageIQ/manageiq-v2v/hammer: https://github.com/ManageIQ/manageiq-v2v/commit/3279653da8e94ddb98c5787f21f02c3322850f45 commit 3279653da8e94ddb98c5787f21f02c3322850f45 Author: Michael Ro <mikerodev> AuthorDate: Fri Dec 7 11:24:55 2018 -0500 Commit: Michael Ro <mikerodev> CommitDate: Fri Dec 7 11:24:55 2018 -0500 Merge pull request #825 from mturley/settings-max-concurrent-min-1 Settings: enforce a minimum of 1 migration per conversion host (cherry picked from commit f5b8f003df120ae5927fc9ff3b552194fe7ae1e4) https://bugzilla.redhat.com/show_bug.cgi?id=1656961 app/javascript/react/screens/App/Settings/Settings.js | 1 + app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap | 1 + app/javascript/react/screens/App/common/forms/NumberInput.js | 13 +- 3 files changed, 12 insertions(+), 3 deletions(-)
Created attachment 1515175 [details] Not able to set migration per host to zero
Verified in 5.10.0.29.20181211195209_fd990a9
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0212