Bug 1657346 - Review Request: perl-Net-OpenID-Common - Libraries shared between Net::OpenID::Consumer and Net::OpenID::Server
Summary: Review Request: perl-Net-OpenID-Common - Libraries shared between Net::OpenID...
Keywords:
Status: CLOSED DUPLICATE of bug 1205121
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1657347 1657348
TreeView+ depends on / blocked
 
Reported: 2018-12-07 17:25 UTC by Xavier Bachelot
Modified: 2018-12-11 15:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-12-11 12:51:32 UTC
Type: ---
Embargoed:
jplesnik: fedora-review-


Attachments (Terms of Use)

Description Xavier Bachelot 2018-12-07 17:25:26 UTC
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Net-OpenID-Common.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Net-OpenID-Common-1.20-1.fc29.src.rpm

Description:
The Consumer and Server implementations share a few libraries which live
with this module. This module is here largely to hold the version number
and this documentation, though it also incorporates some utility functions
inherited from previous versions of Net::OpenID::Consumer.

Fedora Account System Username: xavierb

Comment 1 Jitka Plesnikova 2018-12-11 11:01:04 UTC
Source file is ok
Summary is ok
License is ok
Description is ok

FIX: Please replace URL link by
     https://metacpan.org/release/Net-OpenID-Common
     and Source0 by
     https://cpan.metacpan.org/authors/id/W/WR/WROG/Net-OpenID-Common-%{version}.tar.gz

All tests passed

BuildRequires
FIX: Please add build-requires 
     - perl(utf8) - t/05-eq.t:5
     - perl-interpreter, make, findutils, coreutils - used in spec file

$ rpm -qp --requires perl-Net-OpenID-Common-1.20-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Crypt::DH::GMP)
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(fields)
      1 perl(HTML::Parser)
      1 perl(HTTP::Headers::Util)
      1 perl(HTTP::Message) >= 5.814
      1 perl(HTTP::Request)
      1 perl(HTTP::Status)
      1 perl(Math::BigInt)
      1 perl(MIME::Base64)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Net::OpenID::Common)
      1 perl(Net::OpenID::Extension)
      1 perl(Net::OpenID::ExtensionMessage)
      1 perl(Net::OpenID::URIFetch)
      1 perl(Net::OpenID::Yadis::Service)
      1 perl(strict)
      1 perl(Time::Local)
      1 perl(URI::Escape)
      1 perl(warnings)
      1 perl(XML::Simple)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-OpenID-Common-1.20-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Net::OpenID::Common) = 1.20
      1 perl-Net-OpenID-Common = 1.20-1.fc30
      1 perl(Net::OpenID::Extension) = 1.20
      1 perl(Net::OpenID::ExtensionMessage) = 1.20
      1 perl(Net::OpenID::Extension::SimpleRegistration) = 1.20
      1 perl(Net::OpenID::Extension::SimpleRegistration::Request) = 1.20
      1 perl(Net::OpenID::Extension::SimpleRegistration::Response) = 1.20
      1 perl(Net::OpenID::IndirectMessage) = 1.20
      1 perl(Net::OpenID::URIFetch) = 1.20
      1 perl(Net::OpenID::URIFetch::Response) = 1.20
      1 perl(Net::OpenID::Yadis) = 1.20
      1 perl(Net::OpenID::Yadis::Service) = 1.20
      1 perl(OpenID::util) = 1.20
Binary provides are Ok.

$ rpmlint ./perl-Net-OpenID-Common*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct all 'FIX' issues.

Otherwise, the package looks good. 
Approved.

Comment 2 Jitka Plesnikova 2018-12-11 12:51:32 UTC
The package already exists. 
https://src.fedoraproject.org/rpms/perl-Net-OpenID-Common

*** This bug has been marked as a duplicate of bug 1205121 ***

Comment 3 Jitka Plesnikova 2018-12-11 12:59:05 UTC
Do you want to create EPEL branch?

Comment 4 Xavier Bachelot 2018-12-11 15:43:30 UTC
Yes, I would like to have an EL7 branch please.
The spec will need some small changes to not make use of NO_PACKLIST=1.

Comment 5 Xavier Bachelot 2018-12-11 15:44:45 UTC
And sorry for wasting your time on the duplicate review.


Note You need to log in before you can comment on or make changes to this bug.