Bug 1657746
| Summary: | [RHOSP10][os-collect-config]Interfaces are not properly removed from bonds after network configuration failed | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Alex Stupnikov <astupnik> |
| Component: | os-net-config | Assignee: | Bob Fournier <bfournie> |
| Status: | CLOSED ERRATA | QA Contact: | Alexander Chuzhoy <sasha> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 10.0 (Newton) | CC: | apevec, astupnik, bfournie, dprince, hbrock, jslagle, lhh, mburns |
| Target Milestone: | --- | Keywords: | Triaged, ZStream |
| Target Release: | 10.0 (Newton) | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | os-net-config-5.2.3-4.el7ost | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-04-30 16:58:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alex Stupnikov
2018-12-10 11:08:33 UTC
Hi Alex, Can we get the nic config template files that were used - i.e. controller.yaml, compute.yaml? It doesn't look like they are in the sosreport. It sounds like a valid issue, we will try to duplicate. Thanks. Hi Bob. Asked customer to provide templates. BR, Alex. Thanks Alex. I think I understand what's going on and it there appears to be a patch that needs to be backported to OSP-10 to fix this. To summarize the issue: - eno50 is configured properly as a slave in bond by os-net-config Dec 7 04:12:45 localhost os-collect-config: [2018/12/07 04:12:45 AM] [INFO] running ifdown on interface: eno50 Dec 7 04:12:45 localhost os-collect-config: [2018/12/07 04:12:45 AM] [INFO] Writing config /etc/sysconfig/network-scripts/ifcfg-eno50 Dec 7 04:12:53 localhost os-collect-config: [2018/12/07 04:12:53 AM] [INFO] running ifup on interface: eno50 Dec 7 04:12:54 localhost kernel: bond0: Enslaving eno50 as a backup interface with an up link - a separate interface defined on the compute - nic5 - does not get mapped and appears to not be connected. When ifup is run on this interface it causes an os-net-config crash because the exception is not properly handled: Dec 7 04:12:54 localhost os-collect-config: [2018/12/07 04:12:54 AM] [INFO] running ifup on interface: nic5 Dec 7 04:12:54 localhost /etc/sysconfig/network-scripts/ifup-eth: Device nic5 does not seem to be present, delaying initialization. Dec 7 04:12:54 localhost os-collect-config: Traceback (most recent call last): Dec 7 04:12:54 localhost os-collect-config: File "/usr/bin/os-net-config", line 10, in <module> Dec 7 04:12:54 localhost os-collect-config: sys.exit(main()) Dec 7 04:12:54 localhost os-collect-config: File "/usr/lib/python2.7/site-packages/os_net_config/cli.py", line 187, in main Dec 7 04:12:54 localhost os-collect-config: activate=not opts.no_activate) Dec 7 04:12:54 localhost os-collect-config: File "/usr/lib/python2.7/site-packages/os_net_config/impl_ifcfg.py", line 972, in apply Dec 7 04:12:54 localhost os-collect-config: self.ifup(interface) Dec 7 04:12:54 localhost os-collect-config: File "/usr/lib/python2.7/site-packages/os_net_config/__init__.py", line 244, in ifup Dec 7 04:12:54 localhost os-collect-config: self.execute(msg, '/sbin/ifup', interface) Dec 7 04:12:54 localhost os-collect-config: File "/usr/lib/python2.7/site-packages/os_net_config/__init__.py", line 224, in execute Dec 7 04:12:54 localhost os-collect-config: processutils.execute(cmd, *args, **kwargs) Dec 7 04:12:54 localhost os-collect-config: File "/usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 394, in execute Dec 7 04:12:54 localhost os-collect-config: cmd=sanitized_cmd) Dec 7 04:12:54 localhost os-collect-config: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command. Dec 7 04:12:54 localhost os-collect-config: Command: /sbin/ifup nic5 Dec 7 04:12:54 localhost os-collect-config: Exit code: 1 Dec 7 04:12:54 localhost os-collect-config: Stdout: u'ERROR : [/etc/sysconfig/network-scripts/ifup-eth] Device nic5 does not seem to be present, delaying initialization.\n' - after the os-net-config crash configure_safe_defaults is run Dec 7 04:12:54 localhost os-collect-config: + configure_safe_defaults - since there has been no change to eno50 it is still configured as a slave (addr_assign_type=3) so its skipped in configure_safe_defaults Dec 7 04:13:24 localhost os-collect-config: ++ cat /sys/class/net/eno50/addr_assign_type Dec 7 04:13:24 localhost os-collect-config: + local mac_addr_type=3 Dec 7 04:13:24 localhost os-collect-config: + '[' 3 '!=' 0 ']' Dec 7 04:13:24 localhost os-collect-config: + echo 'Device has generated MAC, skipping.' The problem is really the os-net-config crash by not handling the ifup exception. This has been fixed here https://review.openstack.org/#/c/467311/ and it solves a similar problem. This fix is not present in OSP-10, it should be backported. Once the backport is done we can provide a hot_fix for the customer to test. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0921 |