Bug 1657966 - copy_file_range.2 has incorrect function decl
Summary: copy_file_range.2 has incorrect function decl
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: man-pages
Version: 31
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Nikola Forró
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2018-12-10 20:44 UTC by Kaleb KEITHLEY
Modified: 2019-08-13 16:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed:

Attachments (Terms of Use)

Description Kaleb KEITHLEY 2018-12-10 20:44:53 UTC
Description of problem:

copy_file_range.2 has:

       ssize_t copy_file_range(int fd_in, loff_t *off_in,
                               int fd_out, loff_t *off_out,
                               size_t len, unsigned int flags);
/usr/include/unistd.h has:

ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
                         int __outfd, __off64_t *__poutoff,
                         size_t __length, unsigned int __flags);

Note loff_t versus __off64_t

AFAICT loff_t is a kernel type that is not usually used in user space.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

Comment 1 Kaleb KEITHLEY 2018-12-10 20:54:10 UTC
And it's causing confusion for gluster devs who are copying the man page but are puzzled by the discrepancy between the man page and the decl in <unistd.h>

Comment 2 Nikola Forró 2019-01-07 14:00:53 UTC
copy_file_range.2 man page describes Linux system call (section 2 - system calls (functions provided by the kernel)), so I believe the use of loff_t is appropriate.
__off64_t seems to be a type private to glibc.

Comment 3 Ben Cotton 2019-08-13 16:49:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Note You need to log in before you can comment on or make changes to this bug.