From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050720 Fedora/1.0.6-1.1.fc4 Firefox/1.0.6 Description of problem: Please review the latest cproto spec and propose changes if needed before Extras inclusion. There's no review needed since it's the former Core package, but I think it's not bad to review it anyway. The cproto SRPM is located at: http://people.redhat.com/jnovy/files/cproto-4.7c-6.src.rpm Thanks. Version-Release number of selected component (if applicable): cproto-4.7c-6 How reproducible: Always Steps to Reproduce: Reproduction isn't needed. Additional info:
$ rpmlint cproto-4.7c-6.src.rpm W: cproto summary-ended-with-dot Generates function prototypes and variable declarations from C code. W: cproto no-url-tag W: cproto redundant-prefix-tag W: cproto hardcoded-path-in-buildroot-tag /var/tmp/%{name}-root W: cproto patch-not-applied Patch1: cproto-4.6.1-patch W: cproto patch-not-applied Patch3: cproto-4.6-bison.patch W: cproto patch-not-applied Patch2: cproto-4.6-varargs.patch > ./configure: line 3351: yacc: command not found > make: yacc: Command not found > make: *** [y.tab.c] Error 127 BuildRequires: byacc > %configure --exec-prefix=%{_prefix} The --exec-prefix=... argument is set by %configure already. > ./grammar.y:824:21: error: lex.yy.c: No such file or directory > ./grammar.y: In function 'yaccError': > ./grammar.y:832: error: 'yytext' undeclared (first use in this function) BuildRequires: flex > Prefix: %{_prefix} This is not only redundant (see rpmlint warning), it marks the package as being relocatable (man rpm). If you really want that, please add a comment in the spec file, which says so. At present, the package is relocatable (also because of cproto's options -I and -E).
Thanks for the review. If there are no other objections, I'll import and build this version of cproto: http://people.redhat.com/jnovy/files/cproto-4.7c-7.src.rpm
"There's no review needed since it's the former Core package" Just a reminder: This is no longer valid. All FE packages must be reviewed, whether they were in Core once or not.
Looks okay packaging-wise. Changing to FE-ACCEPT. These changes are still preferred by packaging guidelines and rpmlint: --- cproto.spec.orig 2005-08-13 15:42:41.000000000 +0200 +++ cproto.spec 2005-08-16 23:52:14.000000000 +0200 @@ -1,4 +1,4 @@ -Summary: Generates function prototypes and variable declarations from C code. +Summary: Generates function prototypes and variable declarations from C code Name: cproto Version: 4.7c Release: 7 @@ -7,7 +7,7 @@ Source: ftp://invisible-island.net/cproto/cproto-4_7c.tgz URL: http://invisible-island.net/ BuildRequires: byacc, flex -BuildRoot: %{_tmppath}/%{name}-root +BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %description Cproto generates function prototypes and variable declarations from C
Ok, applied. The cproto package is now imported and initial build is in progress. Thanks.
I don't think it's properly enqueued. http://buildsys.fedoraproject.org/build-status/indiv.psp?email=jnovy%40redhat.com You should be using "make plague" to enqueue build requests, not "make build". http://fedoraproject.org/wiki/Extras/BuildRequests
The "tobuild" file is still imported by Seth from time to time, isn't it? Else the move from "make build" to "make plague" has been unclear and confusing to several packagers. In particular, since "make build" will use plague-client as soon as the testing period is over.
Package cproto enqueued. Job ID: 83. Michael, yes, make plague doesn't look too intuitive ;-) I would be nice to see make build working again.
Michael, yes it is but school starts this week so I've been very busy. Could I ask you to enqueue those builds?