+++ This bug was initially created as a clone of Bug #1619873 +++
[[thaller:REDACTED, see original bug for all details]]
Description of problem:
It seems that captive portal detection does not work in Fedora. Whenever I connect to a network with captive portal, the network does not work until I open FF, which luckily detect the captive portal and lets me log in, but this used to be done by NM together with Gnome if I am not mistaken.
Version-Release number of selected component (if applicable):
$ rpm -q NetworkManager
$ rpm -q gnome-shell
The captive portal is not detected/login window is not displayed.
The captive portal is detected/login window is displayed.
--- Additional comment from Thomas Haller on 2018-12-03 09:13:10 UTC ---
in the log, there are two devices: virbr0 and wlp58s0.
Connectivity check on virbr0, always returns LIMITED (as expected)
Connectivity check on wlp58s0 changes from LIMITED -> PORTAL -> FULL (also expected).
The global connectivity state is the combination of the per-device state.
So we see first:
manager: connectivity checking indicates LIMITED
manager: connectivity checking indicates FULL
That is, because of https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/src/nm-manager.c?id=ba6c2211e8f6aebc5e5b07b77ffee938593980a6#n2829
note, how the "best" connectivity state is just the numeric maxiumum.
However, that way, PORTAL is worse than LIMITED: https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/libnm-core/nm-dbus-interface.h?id=ba6c2211e8f6aebc5e5b07b77ffee938593980a6#n181
Broken since 1.10.0 ( https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6b7e9f9b225e81d365fd95901a88a7bc59c1eb39 )
--- Additional comment from Thomas Haller on 2018-12-11 10:39:42 UTC ---
(In reply to Thomas Haller from comment #9)
> fix here: https://github.com/NetworkManager/NetworkManager/pull/255
this got merged to master as https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b7429d0a95eda7cada2bde7634ba0a7f31eeb18d
A relevant fix got backported to branches
I think, on those branches there is still a subtle issue which is fixed on master . But that requires too many changes for a backporting. So, I presume, the fix on the stable branches are sufficient.
while at it, also backport the fix for crash https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=7f05debf99ab30227180acd7b24a363013c957f2
This patch is merged upsteam for months already (giving confidence that it's good). Also, the crash is indeed nasty.
With this, src/nm-connectivity.[hc] in rhel-8 build is identical to current upstream nm-1-14 branch.
After activation of connection `nmcli general` shows conectivity portal, but gnome does not show any dialog to login (it looks like gnome-shell part). After login in FF, connectivity is full and after logout in firefox, connectivity is changed back to portal. So, NM part works, putting to VERIFIED.