Bug 1658393 - multiple-nic sample template only add routes to External and Tenant interface
Summary: multiple-nic sample template only add routes to External and Tenant interface
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates
Version: 14.0 (Rocky)
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: z1
: 14.0 (Rocky)
Assignee: Harald Jensås
QA Contact: Gurenko Alex
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-12-11 23:25 UTC by Harald Jensås
Modified: 2019-03-18 13:03 UTC (History)
4 users (show)

Fixed In Version: openstack-tripleo-heat-templates-9.2.1-0.20190119154860.fe11ade.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-18 13:03:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 613683 0 None MERGED Fix multiple-nic sample template 2020-12-26 20:58:05 UTC
OpenStack gerrit 617108 0 None MERGED Fix multiple-nic sample template 2020-12-26 20:58:05 UTC
Red Hat Product Errata RHBA-2019:0446 0 None None None 2019-03-18 13:03:31 UTC

Description Harald Jensås 2018-12-11 23:25:39 UTC
Description of problem:
Routes where only added to the External and Tenant interface.

Version-Release number of selected component (if applicable):


How reproducible:
Deploy overcloud using environments/net-multiple-nics.yaml

Actual results:
Routes are only added to the External and Tenant interface.

Expected results:
Routes should be added to all networks.

Additional info:
File: network/config/multiple-nics/role.role.j2.yaml

#######
### Condition to do below for non External|Tenant net.
#######
{%- if network.name not in ["External", "Tenant"] %}
  {%- if network.name in role.networks %}
              - type: interface
                name: nic{{loop.index + 1}}
                use_dhcp: false
                addresses:
                - ip_netmask:
                    get_param: {{network.name}}IpSubnet
  {%- endif %}
########
## elif ...
########
{%- elif network.name in role.networks or role.name == 'Networker' or role.name == 'ComputeDVR' %}
              - type: ovs_bridge
  {%- if network.name == "External" %}
                name: bridge_name
  {%- else %}
                name: br-{{network.name_lower}}
  {%- endif %}
                use_dhcp: false
  {%- if network.name in role.networks %}
                addresses:
                - ip_netmask:
                    get_param: {{network.name}}IpSubnet
  {%- endif %}
#######
### Routes added here
#######
                routes:
                    list_concat_unique:
                      - get_param: {{network.name}}InterfaceRoutes
  {%- if network.name in role.default_route_networks %}
                      - - default: true
                          next_hop:
                            get_param: {{network.name}}InterfaceDefaultRoute
  {%- endif %}
                members:
                - type: interface
                  name: nic{{loop.index + 1}}
                  use_dhcp: false
                  primary: true
#######
## endif
#######
{%- endif %}

The routes should be added in the first section prior to the 'elif' to ensure the other (non External|Internal) network interfaces get's the correct routes configured.

Comment 5 Bob Fournier 2019-03-06 15:07:42 UTC
This is a sample template change only.  I have verified that the fix has been made to the template.

Comment 8 errata-xmlrpc 2019-03-18 13:03:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0446


Note You need to log in before you can comment on or make changes to this bug.