Bug 1658452 - Review Request: python-flasgger - Easy Swagger UI for your Flask API
Summary: Review Request: python-flasgger - Easy Swagger UI for your Flask API
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
Whiteboard: AwaitingSubmitter
Depends On:
TreeView+ depends on / blocked
Reported: 2018-12-12 07:37 UTC by Jan Kaluža
Modified: 2020-03-20 07:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-03-20 07:46:19 UTC
Type: ---

Attachments (Terms of Use)

Description Jan Kaluža 2018-12-12 07:37:25 UTC
Spec URL: http://jkaluza.fedorapeople.org/python-flasgger.spec
SRPM URL: http://jkaluza.fedorapeople.org/python-flasgger-0.9.2-1.src.rpm
Description: Flasgger is a Flask extension to extract OpenAPI Specification from all Flask views registered in your API.
Fedora Account System Username: jkaluza

F28 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31419810

Comment 1 Mikolaj Izdebski 2018-12-12 07:40:49 UTC
Required by ODCS. I will do the review.

Comment 2 Mikolaj Izdebski 2018-12-13 04:22:19 UTC
Spec file is legible. BuildRequires are correct. Package builds fine on x86_64.

rpmlint output:
python3-flasgger.noarch: E: zero-length /usr/lib/python3.7/site-packages/flasgger/ui2/static/css/typography.css
2 packages and 0 specfiles checked; 1 errors, 0 warnings.

python3-flasgger contains JavaScript object code that is not built from source. That included bundled libraries that are packaged separately. This is not acceptable - the code must be built from source. Moreover, you should make effort to avoid shipping bundled libraries - they should be (but don't have to be) packaged separately.

Comment 3 Mikolaj Izdebski 2019-04-09 18:19:29 UTC
Review is stalled. I'm removing myself from assignee.

Note You need to log in before you can comment on or make changes to this bug.