Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.shlomifish.org/Files/files/code/perl-Games-Solitaire-Verify.spec SRPM URL: https://www.shlomifish.org/Files/files/arcs/perl-Games-Solitaire-Verify-0.1900-1.fc29.src.rpm Description: perl-Games-Solitaire-Verify - Perl 5/CPAN distribution to verify/validate solutions of Solitaire card games. This is needed by the test suite of https://apps.fedoraproject.org/packages/freecell-solver which I'd like to run in its RPM's "%check" stage. Fedora Account System Username: shlomif.
- Group: is not used in Fedora - COPYING must be installed with %license, not %doc %files %license COPYING %doc Changes LICENSE META.json META.yml MYMETA.yml README examples URL and Source addresses are Ok. Source archive (SHA-256: 6b17847bd69da05ee089562cf40f2aac15e64c113175eca4fb501d4e86b48181) is original. Ok. Summary verified from lib/Games/Solitaire/Verify.pm. Ok. Description verified from lib/Games/Solitaire/Verify.pm. Ok. License verified from lib/Games/Solitaire/Verify.pm and README. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-Games-Solitaire-Verify.spec review-perl-Games-Solitaire-Verify/results/perl-Games-Solitaire-Verify-0.1900-1.fc30.noarch.rpm review-perl-Games-Solitaire-Verify/results/perl-Games-Solitaire-Verify-0.1900-1.fc30.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-Games-Solitaire-Verify-0.1900-1.fc30.noarch.rpm 18:09:43 -rwxr-xr-x 1 root root 5525 déc. 12 18:08 /usr/bin/expand-solitaire-multi-card-moves -rwxr-xr-x 1 root root 5660 déc. 12 18:08 /usr/bin/verify-solitaire-solution drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/doc/perl-Games-Solitaire-Verify -rw-r--r-- 1 root root 1291 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/COPYING -rw-r--r-- 1 root root 7935 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/Changes -rw-r--r-- 1 root root 1158 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/LICENSE -rw-r--r-- 1 root root 20320 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/META.json -rw-r--r-- 1 root root 13082 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/META.yml -rw-r--r-- 1 root root 13082 déc. 12 18:08 /usr/share/doc/perl-Games-Solitaire-Verify/MYMETA.yml -rw-r--r-- 1 root root 310 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/README drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/doc/perl-Games-Solitaire-Verify/examples -rw-r--r-- 1 root root 2828 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/examples/benchmark.pl -rw-r--r-- 1 root root 14286 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/examples/dbm_fc_solver_solution_translation.pl -rw-r--r-- 1 root root 472 août 2 15:34 /usr/share/doc/perl-Games-Solitaire-Verify/examples/expand-moves-driver.pl -r--r--r-- 1 root root 3833 déc. 12 18:08 /usr/share/man/man1/expand-solitaire-multi-card-moves.1.gz -r--r--r-- 1 root root 3930 déc. 12 18:08 /usr/share/man/man1/verify-solitaire-solution.1.gz -r--r--r-- 1 root root 3526 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify.3pm.gz -r--r--r-- 1 root root 3353 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::App::CmdLine.3pm.gz -r--r--r-- 1 root root 3347 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::App::CmdLine::Expand.3pm.gz -r--r--r-- 1 root root 3335 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::App::CmdLine::From_Patsolve.3pm.gz -r--r--r-- 1 root root 3593 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Base.3pm.gz -r--r--r-- 1 root root 4177 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Card.3pm.gz -r--r--r-- 1 root root 3844 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Column.3pm.gz -r--r--r-- 1 root root 3306 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Exception.3pm.gz -r--r--r-- 1 root root 3510 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Foundations.3pm.gz -r--r--r-- 1 root root 3617 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Freecells.3pm.gz -r--r--r-- 1 root root 3446 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::KlondikeTalon.3pm.gz -r--r--r-- 1 root root 3534 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Move.3pm.gz -r--r--r-- 1 root root 3701 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Solution.3pm.gz -r--r--r-- 1 root root 3170 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Solution::Base.3pm.gz -r--r--r-- 1 root root 3685 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Solution::ExpandMultiCardMoves.3pm.gz -r--r--r-- 1 root root 3413 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::Solution::ExpandMultiCardMoves::Lax.3pm.gz -r--r--r-- 1 root root 4450 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::State.3pm.gz -r--r--r-- 1 root root 3184 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::State::LaxParser.3pm.gz -r--r--r-- 1 root root 3605 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::VariantParams.3pm.gz -r--r--r-- 1 root root 3817 déc. 12 18:08 /usr/share/man/man3/Games::Solitaire::Verify::VariantsMap.3pm.gz drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify -r--r--r-- 1 root root 4528 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify.pm drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/App drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/App/CmdLine -r--r--r-- 1 root root 7981 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/App/CmdLine.pm -r--r--r-- 1 root root 7695 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/App/CmdLine/Expand.pm -r--r--r-- 1 root root 12231 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/App/CmdLine/From_Patsolve.pm -r--r--r-- 1 root root 4953 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Base.pm -r--r--r-- 1 root root 9350 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Card.pm -r--r--r-- 1 root root 7387 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Column.pm -r--r--r-- 1 root root 10336 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Exception.pm -r--r--r-- 1 root root 7198 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Foundations.pm -r--r--r-- 1 root root 7446 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Freecells.pm -r--r--r-- 1 root root 6249 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/KlondikeTalon.pm -r--r--r-- 1 root root 6620 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Move.pm drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Solution -r--r--r-- 1 root root 7686 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Solution.pm -r--r--r-- 1 root root 5211 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Solution/Base.pm drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Solution/ExpandMultiCardMoves -r--r--r-- 1 root root 14725 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Solution/ExpandMultiCardMoves.pm -r--r--r-- 1 root root 4801 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/Solution/ExpandMultiCardMoves/Lax.pm drwxr-xr-x 2 root root 0 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/State -r--r--r-- 1 root root 23458 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/State.pm -r--r--r-- 1 root root 5004 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/State/LaxParser.pm -r--r--r-- 1 root root 8672 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/VariantParams.pm -r--r--r-- 1 root root 12063 déc. 12 18:08 /usr/share/perl5/vendor_perl/Games/Solitaire/Verify/VariantsMap.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-Games-Solitaire-Verify-0.1900-1.fc30.noarch.rpm | sort -f | uniq -c 18:10:55 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.8.0 1 perl(autodie) 1 perl(Class::XSAccessor) 1 perl(Data::Dumper) 1 perl(Exception::Class) 1 perl(Games::Solitaire::Verify::App::CmdLine) 1 perl(Games::Solitaire::Verify::App::CmdLine::Expand) 1 perl(Games::Solitaire::Verify::Base) 1 perl(Games::Solitaire::Verify::Card) 1 perl(Games::Solitaire::Verify::Column) 1 perl(Games::Solitaire::Verify::Exception) 1 perl(Games::Solitaire::Verify::Foundations) 1 perl(Games::Solitaire::Verify::Freecells) 1 perl(Games::Solitaire::Verify::Move) 1 perl(Games::Solitaire::Verify::Solution) 1 perl(Games::Solitaire::Verify::Solution::Base) 1 perl(Games::Solitaire::Verify::Solution::ExpandMultiCardMoves) 1 perl(Games::Solitaire::Verify::State) 1 perl(Games::Solitaire::Verify::State::LaxParser) 1 perl(Games::Solitaire::Verify::VariantParams) 1 perl(Games::Solitaire::Verify::VariantsMap) 1 perl(Getopt::Long) 1 perl(IO::Handle) 1 perl(List::MoreUtils) 1 perl(List::Util) 1 perl(parent) 1 perl(POSIX) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $rpm -q --provides -p perl-Games-Solitaire-Verify-0.1900-1.fc30.noarch.rpm 18:11:40 perl(Games::Solitaire::Verify) = 0.1900 perl(Games::Solitaire::Verify::App::CmdLine) = 0.1900 perl(Games::Solitaire::Verify::App::CmdLine::Expand) = 0.1900 perl(Games::Solitaire::Verify::App::CmdLine::From_Patsolve) = 0.1900 perl(Games::Solitaire::Verify::Base) = 0.1900 perl(Games::Solitaire::Verify::Card) = 0.1900 perl(Games::Solitaire::Verify::Column) = 0.1900 perl(Games::Solitaire::Verify::Exception) = 0.1900 perl(Games::Solitaire::Verify::Foundations) = 0.1900 perl(Games::Solitaire::Verify::Freecells) = 0.1900 perl(Games::Solitaire::Verify::KlondikeTalon) = 0.1900 perl(Games::Solitaire::Verify::Move) = 0.1900 perl(Games::Solitaire::Verify::Solution) = 0.1900 perl(Games::Solitaire::Verify::Solution::Base) = 0.1900 perl(Games::Solitaire::Verify::Solution::ExpandMultiCardMoves) = 0.1900 perl(Games::Solitaire::Verify::Solution::ExpandMultiCardMoves::Lax) = 0.1900 perl(Games::Solitaire::Verify::State) = 0.1900 perl(Games::Solitaire::Verify::State::LaxParser) = 0.1900 perl(Games::Solitaire::Verify::VariantParams) = 0.1900 perl(Games::Solitaire::Verify::VariantsMap) = 0.1900 perl-Games-Solitaire-Verify = 0.1900-1.fc30 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=31426099) Ok The package is in line with Fedora and Perl packaging guidelines. Resolution: Package approved. Fix the COPYING install before import.
(In reply to Robert-André Mauchin from comment #1) > - Group: is not used in Fedora > > - COPYING must be installed with %license, not %doc > > %files > %license COPYING > %doc Changes LICENSE META.json META.yml MYMETA.yml README examples > [SNIP] > > The package is in line with Fedora and Perl packaging guidelines. > > Resolution: Package approved. Fix the COPYING install before import. Hi! Sorry for the late response, but should I be the one to fix these issues or should it be someone else? Please clarify.
Yes you should fix this before import. Fix the SPEC, regenerate the SRPM and then import the SRPM.
(In reply to Robert-André Mauchin from comment #3) > Yes you should fix this before import. Fix the SPEC, regenerate the SRPM and > then import the SRPM. Hi! I updated the .spec and .src.rpm at the link and requested a new package on pagure - see https://www.pagure.io/releng/fedora-scm-requests/issue/9319 .
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Games-Solitaire-Verify
Hi! I submitted the package - what else needs to be done?
(In reply to Shlomi Fish from comment #6) > Hi! > > I submitted the package - what else needs to be done? bump! Please reply.